-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: map 'not enough coins' error #2902
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…bs/fuels-ts into dp/not-enough-coins-error
Dhaiwat10
requested review from
digorithm,
arboleya,
Torres-ssf,
danielbate,
nedsalk and
maschad
as code owners
August 12, 2024 11:35
Torres-ssf
previously approved these changes
Aug 29, 2024
arboleya
previously approved these changes
Aug 29, 2024
danielbate
previously approved these changes
Sep 2, 2024
Co-authored-by: Anderson Arboleya <anderson@arboleya.me>
Dhaiwat10
dismissed stale reviews from danielbate, arboleya, Torres-ssf, and maschad
via
September 3, 2024 12:11
3eac820
Co-authored-by: Anderson Arboleya <anderson@arboleya.me>
Dhaiwat10
requested review from
arboleya,
danielbate,
Torres-ssf and
maschad
September 3, 2024 12:12
petertonysmith94
approved these changes
Sep 3, 2024
Torres-ssf
approved these changes
Sep 3, 2024
danielbate
approved these changes
Sep 3, 2024
Coverage Report:
Changed Files:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
not enough coins to fit the target
error #2522Release notes
In this release, we:
Summary
This PR maps the
not enough coins to fit the target error
to a proper readable error message. It also lays down the foundation for adding the mapping of more VM errors like this one (#2467).Checklist
tests
to prove my changesdocs