Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: map 'not enough coins' error #2902

Merged
merged 39 commits into from
Sep 3, 2024
Merged

Conversation

Dhaiwat10
Copy link
Member

@Dhaiwat10 Dhaiwat10 commented Aug 9, 2024

Release notes

In this release, we:

  • Mapped the 'not enough coins' error to a readable error message

Summary

This PR maps the not enough coins to fit the target error to a proper readable error message. It also lays down the foundation for adding the mapping of more VM errors like this one (#2467).

Checklist

  • I addedtests to prove my changes
  • I updated — all the necessary docs
  • I reviewed — the entire PR myself, using the GitHub UI
  • I described — all breaking changes and the Migration Guide

@Dhaiwat10 Dhaiwat10 added the feat Issue is a feature label Aug 9, 2024
@Dhaiwat10 Dhaiwat10 self-assigned this Aug 9, 2024
Torres-ssf
Torres-ssf previously approved these changes Aug 29, 2024
arboleya
arboleya previously approved these changes Aug 29, 2024
apps/docs/src/guide/errors/index.md Outdated Show resolved Hide resolved
apps/docs/src/guide/wallets/wallet-transferring.md Outdated Show resolved Hide resolved
danielbate
danielbate previously approved these changes Sep 2, 2024
Co-authored-by: Anderson Arboleya <anderson@arboleya.me>
Dhaiwat10 and others added 2 commits September 3, 2024 17:42
Co-authored-by: Anderson Arboleya <anderson@arboleya.me>
@Dhaiwat10 Dhaiwat10 enabled auto-merge (squash) September 3, 2024 12:41
Copy link
Contributor

github-actions bot commented Sep 3, 2024

Coverage Report:

Lines Branches Functions Statements
79.43%(-0.15%) 71.89%(-0.1%) 77.7%(-0.32%) 79.53%(-0.18%)
Changed Files:
Ok File (✨=New File) Lines Branches Functions Statements
🔴 packages/account/src/providers/provider.ts 69.08%
(-2.34%)
62.56%
(-0.62%)
70.96%
(-5.78%)
68.77%
(-2.55%)
✨ packages/account/src/providers/utils/handle-gql-error-message.ts 100%
(+100%)
100%
(+100%)
100%
(+100%)
100%
(+100%)
🔴 packages/contract/src/contract-factory.ts 32.6%
(-0.48%)
26.66%
(-0.92%)
34.78%
(-1.58%)
31.91%
(-0.69%)
🔴 packages/errors/src/test-utils/expect-to-throw-fuel-error.ts 92%
(-4%)
88.88%
(-5.56%)
100%
(+0%)
92%
(-4%)

@Dhaiwat10 Dhaiwat10 merged commit a059ea1 into master Sep 3, 2024
23 checks passed
@Dhaiwat10 Dhaiwat10 deleted the dp/not-enough-coins-error branch September 3, 2024 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat Issue is a feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Map not enough coins to fit the target error
7 participants