Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Account.createTransfer return type #2926

Merged
merged 4 commits into from
Aug 14, 2024

Conversation

Torres-ssf
Copy link
Contributor

@Torres-ssf Torres-ssf commented Aug 13, 2024

Summary

Use ScriptTransactionRequest instead of TransactionRequest as the returning type of the Account method createTransfer

Checklist

  • All changes are covered by tests (or not applicable)
  • All changes are documented (or not applicable)
  • I reviewed the entire PR myself (preferably, on GH UI)
  • I described all Breaking Changes (or there's none)

@Torres-ssf Torres-ssf enabled auto-merge (squash) August 13, 2024 14:36
Copy link
Contributor

Coverage Report:

Lines Branches Functions Statements
79.33%(+0%) 71.57%(+0%) 77.55%(+0%) 79.48%(+0%)
Changed Files:

Coverage values did not change👌.

@Torres-ssf Torres-ssf merged commit a467d54 into master Aug 14, 2024
20 checks passed
@Torres-ssf Torres-ssf deleted the st/fix/create-transfer-return-type branch August 14, 2024 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue is a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants