Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: consistent typegen outputs #3040

Merged
merged 4 commits into from
Aug 27, 2024

Conversation

petertonysmith94
Copy link
Contributor

@petertonysmith94 petertonysmith94 commented Aug 27, 2024

Summary

  • The compression of our bytecode is including a modified timestamp so the output of typegen is different in sequential runs. This PR fixes the modified timestamp to ensure the results of compression are equal.
  • Showcase of failure and success.

Checklist

  • All changes are covered by tests (or not applicable)
  • All changes are documented (or not applicable)
  • I reviewed the entire PR myself (preferably, on GH UI)
  • I described all Breaking Changes (or there's none)

@petertonysmith94 petertonysmith94 changed the title chore: added test to display failure fix: consistent typegen outputs Aug 27, 2024
Copy link

vercel bot commented Aug 27, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
create-fuels-counter-example ⬜️ Ignored (Inspect) Aug 27, 2024 8:17pm
create-fuels-template-preview ⬜️ Ignored (Inspect) Aug 27, 2024 8:17pm

Copy link
Contributor

Coverage Report:

Lines Branches Functions Statements
79.42%(+0%) 71.86%(+0.07%) 77.7%(-0.14%) 79.55%(+0%)
Changed Files:
Ok File (✨=New File) Lines Branches Functions Statements
🔴 packages/abi-coder/src/utils/transpile-abi.ts 100%
(+2.64%)
91.66%
(+4.16%)
94.11%
(+0%)
97.72%
(+2.27%)
🔴 packages/account/src/connectors/fuel.ts 95.39%
(-1.16%)
90.66%
(+1.33%)
88.88%
(-6.35%)
95.56%
(-1.12%)

Copy link
Member

@maschad maschad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work 🚀 - tested it out locally and works well.

@petertonysmith94 petertonysmith94 merged commit 01e2f0e into master Aug 27, 2024
23 checks passed
@petertonysmith94 petertonysmith94 deleted the ps/fix/bytecode-compression-inconsistent branch August 27, 2024 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue is a bug chore Issue is a chore
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Typegen producing inconsistent outputs between runs
4 participants