Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: UtxoIdCoder output index to be u16 #3064

Merged
merged 6 commits into from
Aug 30, 2024
Merged

fix: UtxoIdCoder output index to be u16 #3064

merged 6 commits into from
Aug 30, 2024

Conversation

danielbate
Copy link
Member

@danielbate danielbate commented Aug 30, 2024 •
edited
Loading

Summary

Fixes the UtxoIdCoder so output index is encoded as u16. We do not use this coder anywhere internally hence there has been no issues, but we do export it from fuels.

Checklist

  • All changes are covered by tests (or not applicable)
  • All changes are documented (or not applicable)
  • I reviewed the entire PR myself (preferably, on GH UI)
  • I described all Breaking Changes (or there's none)

@danielbate danielbate added the bug Issue is a bug label Aug 30, 2024
@danielbate danielbate self-assigned this Aug 30, 2024
@vercel Vercel
Copy link

vercel bot commented Aug 30, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
create-fuels-template ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 30, 2024 0:27am
ts-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 30, 2024 0:27am
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
create-fuels-counter-example ⬜️ Ignored (Inspect) Aug 30, 2024 0:27am

@danielbate danielbate marked this pull request as ready for review August 30, 2024 11:20
arboleya
arboleya previously approved these changes Aug 30, 2024
View reviewed changes
packages/transactions/src/coders/utxo-id.test.ts Outdated Show resolved Hide resolved
Torres-ssf
Torres-ssf previously approved these changes Aug 30, 2024
View reviewed changes
@danielbate danielbate dismissed stale reviews from Torres-ssf and arboleya via d39f23f August 30, 2024 12:20
Torres-ssf
Torres-ssf approved these changes Aug 30, 2024
View reviewed changes
Copy link
Contributor

@Torres-ssf Torres-ssf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch @danielbate 🚀

@danielbate danielbate enabled auto-merge (squash) August 30, 2024 12:27
@github-actions GitHub Actions
Copy link
Contributor

Coverage Report:

Lines Branches Functions Statements
79.42%(+0%) 71.86%(+0%) 77.7%(+0%) 79.55%(+0%)
Changed Files:

Coverage values did not change👌.

@danielbate danielbate merged commit e286557 into master Aug 30, 2024
23 checks passed
@danielbate danielbate deleted the db/fix/utxo-id-output-index-u16 branch August 30, 2024 12:42
@fuel-service-user fuel-service-user mentioned this pull request Aug 30, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Torres-ssf Torres-ssf Torres-ssf approved these changes

@petertonysmith94 petertonysmith94 petertonysmith94 approved these changes

@arboleya arboleya arboleya approved these changes

@digorithm digorithm Awaiting requested review from digorithm digorithm is a code owner

@Dhaiwat10 Dhaiwat10 Awaiting requested review from Dhaiwat10 Dhaiwat10 is a code owner

@nedsalk nedsalk Awaiting requested review from nedsalk nedsalk is a code owner

@maschad maschad Awaiting requested review from maschad maschad is a code owner

Assignees

@danielbate danielbate

Labels
bug Issue is a bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

UtxoIdCoder output index should be u16
4 participants
@danielbate @arboleya @petertonysmith94 @Torres-ssf