Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: removed redundant crypto functionality #3075

Merged
merged 3 commits into from
Sep 3, 2024

Conversation

petertonysmith94
Copy link
Contributor

@petertonysmith94 petertonysmith94 commented Sep 2, 2024

Release notes

In this release, we:

  • Deprecated the error code HASHER_LOCKED

Summary

  • Removed unexposed Node functions lock and register for hmac and pdkdf2 crypto functions.
  • Added deprecation notice to error code HASHER_LOCKED

Checklist

  • All changes are covered by tests (or not applicable)
  • All changes are documented (or not applicable)
  • I reviewed the entire PR myself (preferably, on GH UI)
  • I described all Breaking Changes (or there's none)

@petertonysmith94 petertonysmith94 added the chore Issue is a chore label Sep 2, 2024
@petertonysmith94 petertonysmith94 self-assigned this Sep 2, 2024
Copy link

vercel bot commented Sep 2, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
create-fuels-template ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 3, 2024 2:00pm
ts-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 3, 2024 2:00pm
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
create-fuels-counter-example ⬜️ Ignored (Inspect) Sep 3, 2024 2:00pm

@petertonysmith94 petertonysmith94 changed the title Ps/chore/remove redundant crypto methods chore: removed redundant crypto functionality Sep 2, 2024
@petertonysmith94 petertonysmith94 marked this pull request as ready for review September 2, 2024 06:26
Copy link
Member

@maschad maschad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM just left one comment

@danielbate
Copy link
Member

Should we be referencing deprecations in PR descriptions or changesets? 🤔

@petertonysmith94
Copy link
Contributor Author

petertonysmith94 commented Sep 3, 2024

Should we be referencing deprecations in PR descriptions or changesets? 🤔

I wonder if deprecation notices should be in a section of their own - I can add to the release notes for now.

Edit: Updated the release notes only with the deprecation, I'm not sure if saying about the removal of the methods would be wise (so that's in the summary).

Copy link
Contributor

github-actions bot commented Sep 3, 2024

Coverage Report:

Lines Branches Functions Statements
79.52%(+0.09%) 72.04%(+0.16%) 78.04%(+0.35%) 79.62%(+0.09%)
Changed Files:
Ok File (✨=New File) Lines Branches Functions Statements
🔴 packages/account/src/providers/provider.ts 69.08%
(+0%)
62.56%
(+0%)
70.96%
(-0.31%)
68.77%
(+0%)
✨ packages/account/src/providers/utils/handle-gql-error-message.ts 100%
(+100%)
100%
(+100%)
100%
(+100%)
100%
(+100%)
🔴 packages/crypto/src/node/hmac.ts 0%
(-46.66%)
100%
(+100%)
0%
(+0%)
0%
(-46.66%)
🔴 packages/crypto/src/node/pbkdf2.ts 0%
(-46.66%)
100%
(+100%)
0%
(+0%)
0%
(-46.66%)
packages/crypto/src/shared/ripemd160.ts 100%
(+30.77%)
100%
(+100%)
100%
(+50%)
100%
(+28.58%)
🔴 packages/errors/src/test-utils/expect-to-throw-fuel-error.ts 92%
(-4%)
88.88%
(-5.56%)
100%
(+0%)
92%
(-4%)

@petertonysmith94 petertonysmith94 merged commit 482bbf0 into master Sep 3, 2024
23 checks passed
@petertonysmith94 petertonysmith94 deleted the ps/chore/remove-redundant-crypto-methods branch September 3, 2024 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Issue is a chore
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove redundant crypto methods
5 participants