Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: add initial benchmark infrastructure #3084

Merged
merged 38 commits into from
Sep 12, 2024
Merged

ci: add initial benchmark infrastructure #3084

merged 38 commits into from
Sep 12, 2024

Conversation

maschad
Copy link
Member

@maschad maschad commented Sep 3, 2024 •
edited
Loading

Closes TS-604

Summary

This PR seeks to introduce some initial benchmarks that will be on master post-merge. It adds some metrics around base functions of the SDK and is by no means a finished product. The overall intention is to eventually run these benchmarks against nodes in devnet and testnet to get more realistic assessments around consumer's experiences.

Checklist

  • All changes are covered by tests (or not applicable)
  • All changes are documented (or not applicable)
  • I reviewed the entire PR myself (preferably, on GH UI)
  • I described all Breaking Changes (or there's none)

@vercel Vercel
Copy link

vercel bot commented Sep 3, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
create-fuels-template ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 12, 2024 3:20pm
ts-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 12, 2024 3:20pm
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
create-fuels-counter-example ⬜️ Ignored (Inspect) Sep 12, 2024 3:20pm

@github-actions github-actions bot added the feat Issue is a feature label Sep 3, 2024
@maschad maschad changed the title feat: introduce initial wallet benchmark tests WIP: introduce initial wallet benchmark tests Sep 3, 2024
@maschad maschad changed the title WIP: introduce initial wallet benchmark tests WIP: Add benchmark infrastructure Sep 6, 2024
@maschad maschad mentioned this pull request Sep 9, 2024
Open
petertonysmith94
petertonysmith94 reviewed Sep 10, 2024
View reviewed changes
package.json Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
danielbate
danielbate previously approved these changes Sep 10, 2024
View reviewed changes
Copy link
Contributor

@danielbate danielbate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving as this is great work, with one comment on what we are benchmarking.

internal/benchmarks/src/cost-estimation.bench.ts Show resolved Hide resolved
@Torres-ssf
Copy link
Contributor

@maschad I've noticed that we are not benchmarking a deploy contract transaction. I am aware that we forgot to add it to #3043 but I believe this is a valid case to benchmark.

Do you think it is worth to add this case now? Or maybe in a future PR?

@maschad
Copy link
Member Author

maschad commented Sep 10, 2024

Agreed @Torres-ssf c4bbf94

danielbate
danielbate approved these changes Sep 11, 2024
View reviewed changes
Copy link
Contributor

@danielbate danielbate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@github-actions GitHub Actions
Copy link
Contributor

Coverage Report:

Lines Branches Functions Statements
77.2%(-1.67%) 71.61%(-0.03%) 75.81%(-1.38%) 77.31%(-1.64%)
Changed Files:
Ok File (✨=New File) Lines Branches Functions Statements
🔴 ✨ internal/benchmarks/src/contract-interaction.bench.ts 0%
(+0%)		 100%
(+100%)		 0%
(+0%)		 0%
(+0%)
🔴 ✨ internal/benchmarks/src/cost-estimation.bench.ts 0%
(+0%)		 100%
(+100%)		 0%
(+0%)		 0%
(+0%)
🔴 ✨ internal/benchmarks/src/crypto.bench.ts 0%
(+0%)		 100%
(+100%)		 0%
(+0%)		 0%
(+0%)
🔴 ✨ internal/benchmarks/src/transaction-results.bench.ts 0%
(+0%)		 100%
(+100%)		 0%
(+0%)		 0%
(+0%)
🔴 ✨ internal/benchmarks/src/wallet.bench.ts 0%
(+0%)		 100%
(+100%)		 0%
(+0%)		 0%
(+0%)
🔴 packages/account/src/providers/transaction-request/transaction-request.ts 88.57%
(+0%)		 76.71%
(-1.37%)		 84%
(+0%)		 88.81%
(+0%)

@maschad maschad merged commit f76afd2 into master Sep 12, 2024
25 checks passed
@maschad maschad deleted the mc/test/performance-tests branch September 12, 2024 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arboleya arboleya arboleya left review comments

@danielbate danielbate danielbate approved these changes

@Torres-ssf Torres-ssf Torres-ssf approved these changes

@Dhaiwat10 Dhaiwat10 Dhaiwat10 approved these changes

@digorithm digorithm Awaiting requested review from digorithm digorithm is a code owner

@nedsalk nedsalk Awaiting requested review from nedsalk nedsalk is a code owner

@petertonysmith94 petertonysmith94 Awaiting requested review from petertonysmith94 petertonysmith94 is a code owner

Assignees

@maschad maschad

Labels
chore Issue is a chore feat Issue is a feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add basic infra for benchmarks
7 participants
@maschad @Torres-ssf @arboleya @danielbate @petertonysmith94 @nedsalk @Dhaiwat10