-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: return deep clone on transaction request from
method
#3097
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maschad
requested review from
digorithm,
arboleya,
Torres-ssf,
Dhaiwat10,
danielbate,
nedsalk and
petertonysmith94
as code owners
September 3, 2024 19:32
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
maschad
changed the title
fix: return deep clone on transactionRequest from method
fix: return deep clone on transaction request Sep 3, 2024
from
method
maschad
changed the title
fix: return deep clone on transaction request
feat: return deep clone on transaction request Sep 3, 2024
from
methodfrom
method
maschad
commented
Sep 3, 2024
packages/account/src/providers/transaction-request/blob-transaction-request.ts
Show resolved
Hide resolved
arboleya
reviewed
Sep 3, 2024
packages/account/src/providers/transaction-request/script-transaction-request.ts
Show resolved
Hide resolved
Torres-ssf
approved these changes
Sep 3, 2024
danielbate
approved these changes
Sep 4, 2024
petertonysmith94
approved these changes
Sep 4, 2024
Coverage Report:
Changed Files:
|
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ScriptTransactionRequest.from
clone a given transaction #3076Release notes
In this release, we:
from
methodSummary
I've applied this feat to the other
from
methods on the otherBaseTransactionRequest
subclassesChecklist