Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: return deep clone on transaction request from method #3097

Merged
merged 8 commits into from
Sep 4, 2024

Conversation

maschad
Copy link
Member

@maschad maschad commented Sep 3, 2024

Release notes

In this release, we:

  • We now return a deep clone of the transaction request in the static from method

Summary

I've applied this feat to the other from methods on the other BaseTransactionRequest subclasses

Checklist

  • All changes are covered by tests (or not applicable)
  • All changes are documented (or not applicable)
  • I reviewed the entire PR myself (preferably, on GH UI)
  • I described all Breaking Changes (or there's none)

Copy link

vercel bot commented Sep 3, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
create-fuels-template ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 4, 2024 1:46pm
ts-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 4, 2024 1:46pm
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
create-fuels-counter-example ⬜️ Ignored (Inspect) Sep 4, 2024 1:46pm

@github-actions github-actions bot added the bug Issue is a bug label Sep 3, 2024
@maschad maschad changed the title fix: return deep clone on transactionRequest from method fix: return deep clone on transaction request from method Sep 3, 2024
@maschad maschad self-assigned this Sep 3, 2024
@maschad maschad marked this pull request as draft September 3, 2024 19:33
@maschad maschad changed the title fix: return deep clone on transaction request from method feat: return deep clone on transaction request from method Sep 3, 2024
@github-actions github-actions bot added the feat Issue is a feature label Sep 3, 2024
@maschad maschad requested a review from arboleya September 3, 2024 22:17
Copy link
Contributor

github-actions bot commented Sep 4, 2024

Coverage Report:

Lines Branches Functions Statements
79.4%(+0.02%) 72.12%(+0.05%) 77.77%(+0%) 79.47%(+0.02%)
Changed Files:
Ok File (✨=New File) Lines Branches Functions Statements
🔴 packages/account/src/providers/transaction-request/blob-transaction-request.ts 50%
(+0%)
100%
(+25%)
40%
(+0%)
50%
(+0%)
🔴 packages/account/src/providers/transaction-request/create-transaction-request.ts 73.33%
(+2.75%)
66.66%
(+2.38%)
50%
(+0%)
73.33%
(+2.75%)
🔴 packages/account/src/providers/transaction-request/script-transaction-request.ts 43.58%
(-0.32%)
58.33%
(+1.19%)
38.88%
(+0%)
42.5%
(-0.35%)

@maschad maschad merged commit 7fc8d24 into master Sep 4, 2024
23 checks passed
@maschad maschad deleted the mc/fix/return-deep-clone-requests branch September 4, 2024 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat Issue is a feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make ScriptTransactionRequest.from clone a given transaction
5 participants