Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add UI tests to create fuels template #3104

Merged
merged 29 commits into from
Sep 11, 2024
Merged

feat: add UI tests to create fuels template #3104

merged 29 commits into from
Sep 11, 2024

Conversation

Dhaiwat10
Copy link
Member

@Dhaiwat10 Dhaiwat10 commented Sep 4, 2024 •
edited
Loading

Release notes

In this release, we:

  • Added UI tests to the create fuels template app

Summary

After this PR, the create fuels template app will ship with a baked-in UI testing setup.

While adding this setup, I spotted a possible improvement in our current UI tests for the create fuels template that we run in the CI so I made some improvements there as well.

Checklist

  • All changes are covered by tests (or not applicable)
  • All changes are documented (or not applicable)
  • I reviewed the entire PR myself (preferably, on GH UI)
  • I described all Breaking Changes (or there's none)

@Dhaiwat10 Dhaiwat10 added the feat Issue is a feature label Sep 4, 2024
@Dhaiwat10 Dhaiwat10 self-assigned this Sep 4, 2024
@vercel Vercel
Copy link

vercel bot commented Sep 4, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
create-fuels-template ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 11, 2024 6:06pm
ts-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 11, 2024 6:06pm
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
create-fuels-counter-example ⬜️ Ignored (Inspect) Sep 11, 2024 6:06pm

@Dhaiwat10 Dhaiwat10 marked this pull request as ready for review September 5, 2024 04:46
@Dhaiwat10 Dhaiwat10 enabled auto-merge (squash) September 11, 2024 07:58
danielbate
danielbate previously approved these changes Sep 11, 2024
View reviewed changes
maschad
maschad previously approved these changes Sep 11, 2024
View reviewed changes
arboleya
arboleya previously approved these changes Sep 11, 2024
View reviewed changes
@arboleya arboleya self-requested a review September 11, 2024 18:09
@github-actions GitHub Actions
Copy link
Contributor

Coverage Report:

Lines Branches Functions Statements
78.87%(+0%) 71.64%(-0.11%) 77.19%(+0%) 78.95%(+0%)
Changed Files:
Ok File (✨=New File) Lines Branches Functions Statements
🔴 ✨ apps/create-fuels-counter-guide/playwright.config.ts 100%
(+100%)		 0%
(+0%)		 100%
(+100%)		 100%
(+100%)

@Dhaiwat10 Dhaiwat10 merged commit 11d4f8b into master Sep 11, 2024
23 checks passed
@Dhaiwat10 Dhaiwat10 deleted the dp/create-fuels-ui-testing branch September 11, 2024 20:34
@fuel-service-user fuel-service-user mentioned this pull request Sep 11, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Torres-ssf Torres-ssf Torres-ssf approved these changes

@maschad maschad maschad approved these changes

@arboleya arboleya arboleya approved these changes

@danielbate danielbate danielbate left review comments

@digorithm digorithm Awaiting requested review from digorithm digorithm is a code owner

@nedsalk nedsalk Awaiting requested review from nedsalk nedsalk is a code owner

@petertonysmith94 petertonysmith94 Awaiting requested review from petertonysmith94 petertonysmith94 is a code owner

Assignees

@Dhaiwat10 Dhaiwat10

Labels
feat Issue is a feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement UI testing in create fuels
6 participants
@Dhaiwat10 @danielbate @arboleya @maschad @petertonysmith94 @Torres-ssf