-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: made selectNetwork
arguments more flexible
#3160
Merged
petertonysmith94
merged 4 commits into
master
from
ps/chore/allow-select-network-to-accept-optional-params
Sep 13, 2024
Merged
chore: made selectNetwork
arguments more flexible
#3160
petertonysmith94
merged 4 commits into
master
from
ps/chore/allow-select-network-to-accept-optional-params
Sep 13, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
CodSpeed Performance ReportMerging #3160 will improve performances by ×2.6Comparing Summary
Benchmarks breakdown
|
petertonysmith94
requested review from
digorithm,
arboleya,
Torres-ssf,
Dhaiwat10,
danielbate,
nedsalk and
maschad
as code owners
September 13, 2024 07:43
nedsalk
approved these changes
Sep 13, 2024
Coverage Report:
Changed Files:
|
danielbate
approved these changes
Sep 13, 2024
helciofranco
approved these changes
Sep 13, 2024
petertonysmith94
deleted the
ps/chore/allow-select-network-to-accept-optional-params
branch
September 13, 2024 11:48
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
selectNetwork
method to accept optional providerUrl and chainId #3158Release notes
In this release, we:
selectNetwork
connector method now accepts eitherurl
orchainId
or both.Checklist