Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: incorrect coder matching #3162

Merged
merged 6 commits into from
Sep 13, 2024
Merged

fix: incorrect coder matching #3162

merged 6 commits into from
Sep 13, 2024

Conversation

petertonysmith94
Copy link
Contributor

@petertonysmith94 petertonysmith94 commented Sep 13, 2024 •
edited
Loading

TS-653

Release notes

In this release, we:

  • Fixed coder matching for some namespaced libraries

Summary

  • Proof of failure, this should be matched to an Enum.

Checklist

  • All changes are covered by tests (or not applicable)
  • All changes are documented (or not applicable)
  • I reviewed the entire PR myself (preferably, on GH UI)
  • I described all Breaking Changes (or there's none)

@petertonysmith94 petertonysmith94 added the bug Issue is a bug label Sep 13, 2024
@petertonysmith94 petertonysmith94 self-assigned this Sep 13, 2024
@vercel Vercel
Copy link

vercel bot commented Sep 13, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
create-fuels-template ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 13, 2024 0:07am
ts-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 13, 2024 0:07am
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
create-fuels-counter-example ⬜️ Ignored (Inspect) Sep 13, 2024 0:07am

@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Sep 13, 2024 •
edited
Loading

CodSpeed Performance Report

Merging #3162 will improve performances by ×2.9

Comparing ps/fix/incorrect-coder-matching (b01e989) with master (c21096c)

Summary

⚡ 1 improvements
✅ 20 untouched benchmarks

Benchmarks breakdown

Benchmark master ps/fix/incorrect-coder-matching Change
⚡ Instantiate a new Unlocked wallet 106.6 ms 36.8 ms ×2.9

@github-actions GitHub Actions
Copy link
Contributor

This PR is published in NPM with version 0.0.0-pr-3162-20240913112142

@petertonysmith94 petertonysmith94 marked this pull request as ready for review September 13, 2024 11:23
danielbate
danielbate approved these changes Sep 13, 2024
View reviewed changes
Copy link
Contributor

@danielbate danielbate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔍

arboleya
arboleya approved these changes Sep 13, 2024
View reviewed changes
Copy link
Member

@arboleya arboleya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great find. ❤️

@petertonysmith94 petertonysmith94 mentioned this pull request Sep 13, 2024
Merged
4 tasks
@github-actions GitHub Actions
Copy link
Contributor

Coverage Report:

Lines Branches Functions Statements
77.08%(-0.12%) 71.64%(+0%) 75.73%(-0.08%) 77.19%(-0.12%)
Changed Files:
Ok File (✨=New File) Lines Branches Functions Statements
🔴 ✨ apps/create-fuels-counter-guide/vite.config.ts 0%
(+0%)		 100%
(+100%)		 0%
(+0%)		 0%
(+0%)
🔴 ✨ packages/abi-typegen/tsup.config.ts 0%
(+0%)		 100%
(+100%)		 100%
(+100%)		 0%
(+0%)
🔴 ✨ packages/account/tsup.config.ts 0%
(+0%)		 100%
(+100%)		 0%
(+0%)		 0%
(+0%)
🔴 ✨ packages/contract/tsup.config.ts 0%
(+0%)		 100%
(+100%)		 100%
(+100%)		 0%
(+0%)
🔴 ✨ packages/crypto/tsup.config.ts 0%
(+0%)		 100%
(+100%)		 100%
(+100%)		 0%
(+0%)
🔴 ✨ packages/errors/tsup.config.ts 0%
(+0%)		 100%
(+100%)		 100%
(+100%)		 0%
(+0%)
🔴 ✨ packages/fuels/tsup.config.ts 0%
(+0%)		 100%
(+100%)		 100%
(+100%)		 0%
(+0%)
🔴 ✨ packages/transactions/tsup.config.ts 0%
(+0%)		 100%
(+100%)		 100%
(+100%)		 0%
(+0%)
🔴 ✨ packages/utils/tsup.config.ts 0%
(+0%)		 100%
(+100%)		 100%
(+100%)		 0%
(+0%)

@arboleya arboleya merged commit 9719c1b into master Sep 13, 2024
25 checks passed
@arboleya arboleya deleted the ps/fix/incorrect-coder-matching branch September 13, 2024 12:52
@fuel-service-user fuel-service-user mentioned this pull request Sep 13, 2024
Merged
@partylikeits1983
Copy link

When will 94.6 be released?

@petertonysmith94
Copy link
Contributor Author

petertonysmith94 commented Sep 13, 2024 •
edited
Loading

When will 94.6 be released?

We've release 0.94.6 about 12 minutes ago :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nedsalk nedsalk nedsalk approved these changes

@danielbate danielbate danielbate approved these changes

@arboleya arboleya arboleya approved these changes

@digorithm digorithm Awaiting requested review from digorithm digorithm is a code owner

@Torres-ssf Torres-ssf Awaiting requested review from Torres-ssf Torres-ssf is a code owner

@Dhaiwat10 Dhaiwat10 Awaiting requested review from Dhaiwat10 Dhaiwat10 is a code owner

@maschad maschad Awaiting requested review from maschad maschad is a code owner

Assignees

@petertonysmith94 petertonysmith94

Labels
bug Issue is a bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Incorrect coder matching from namespaced library
5 participants
@petertonysmith94 @partylikeits1983 @arboleya @danielbate @nedsalk