Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: removed sepolia assets and adjust decimal config #3167

Merged
merged 12 commits into from
Sep 16, 2024
Merged

fix: removed sepolia assets and adjust decimal config #3167

merged 12 commits into from
Sep 16, 2024

Conversation

LuizAsFight
Copy link
Contributor

@LuizAsFight LuizAsFight commented Sep 14, 2024 •
edited
Loading

Release notes

In this release, we:

  • Removed assets from sepolia / testnet network
  • Fixed decimals of some assets on fuel network side

Summary

We'll not need any assets from sepolia / testnet for now, removing them until we have a final list.
Also some decimal fields in fuel side were 18 which is not possible due to max on fuel being 9. Fixed those changing it to 9

Checklist

  • All changes are covered by tests (or not applicable)
  • All changes are documented (or not applicable)
  • I reviewed the entire PR myself (preferably, on GH UI)
  • I described all Breaking Changes (or there's none)

@vercel Vercel
Copy link

vercel bot commented Sep 14, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
create-fuels-template ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 16, 2024 1:51pm
ts-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 16, 2024 1:51pm
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
create-fuels-counter-example ⬜️ Ignored (Inspect) Sep 16, 2024 1:51pm

@github-actions github-actions bot added the bug Issue is a bug label Sep 14, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 14, 2024 •
edited
Loading

This PR is published in NPM with version 0.0.0-pr-3167-20240915223932

@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Sep 14, 2024 •
edited
Loading

CodSpeed Performance Report

Merging #3167 will not alter performance

Comparing lf/fix/asset-id-sepolia-addresses (bdee16b) with master (431990d)

Summary

✅ 21 untouched benchmarks

@LuizAsFight LuizAsFight changed the title fix: assetId and contractId sepolia addresses fix: some assets got assetId, contractId and decimals incorrect, for sepolia and for fuel network Sep 14, 2024
@LuizAsFight LuizAsFight changed the title fix: some assets got assetId, contractId and decimals incorrect, for sepolia and for fuel network fix: some assets got assetId, contractId and decimals incorrect Sep 14, 2024
@LuizAsFight LuizAsFight marked this pull request as ready for review September 15, 2024 00:11
maschad
maschad previously approved these changes Sep 15, 2024
View reviewed changes
Torres-ssf
Torres-ssf previously approved these changes Sep 15, 2024
View reviewed changes
@LuizAsFight LuizAsFight changed the title fix: some assets got assetId, contractId and decimals incorrect fix(assets): removed sepolia assets and fixed some incorrect decimals config Sep 15, 2024
@maschad maschad changed the title fix(assets): removed sepolia assets and fixed some incorrect decimals config fix: removed sepolia assets and adjust decimal config Sep 16, 2024
@petertonysmith94 @maschad
Update changeset
082a2f5 
Co-authored-by: Chad Nehemiah <chad.nehemiah94@gmail.com>
@github-actions GitHub Actions
Copy link
Contributor

Coverage Report:

Lines Branches Functions Statements
77.13%(+0%) 71.67%(+0%) 75.77%(+0%) 77.24%(+0%)
Changed Files:

Coverage values did not change👌.

@LuizAsFight LuizAsFight merged commit f46334d into master Sep 16, 2024
26 checks passed
@LuizAsFight LuizAsFight deleted the lf/fix/asset-id-sepolia-addresses branch September 16, 2024 14:07
@fuel-service-user fuel-service-user mentioned this pull request Sep 16, 2024
Merged
nedsalk pushed a commit that referenced this pull request Sep 17, 2024
@LuizAsFight @nedsalk
fix: some assets got assetId, contractId and decimals incorrect (#3167)
7096791
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Torres-ssf Torres-ssf Torres-ssf approved these changes

@petertonysmith94 petertonysmith94 petertonysmith94 approved these changes

@maschad maschad maschad approved these changes

@digorithm digorithm Awaiting requested review from digorithm digorithm is a code owner

@arboleya arboleya Awaiting requested review from arboleya arboleya is a code owner

@Dhaiwat10 Dhaiwat10 Awaiting requested review from Dhaiwat10 Dhaiwat10 is a code owner

@danielbate danielbate Awaiting requested review from danielbate danielbate is a code owner

@nedsalk nedsalk Awaiting requested review from nedsalk nedsalk is a code owner

Assignees

@LuizAsFight LuizAsFight

Labels
bug Issue is a bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@LuizAsFight @maschad @petertonysmith94 @Torres-ssf