Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: adjust logger tests #3193

Merged
merged 4 commits into from
Sep 21, 2024
Merged

chore: adjust logger tests #3193

merged 4 commits into from
Sep 21, 2024

Conversation

arboleya
Copy link
Member

@arboleya arboleya commented Sep 20, 2024 •
edited
Loading

Closes TS-659

Checklist

  • All changes are covered by tests (or not applicable)
  • All changes are documented (or not applicable)
  • I reviewed the entire PR myself (preferably, on GH UI)
  • I described all Breaking Changes (or there's none)

@arboleya arboleya added the chore Issue is a chore label Sep 20, 2024
@arboleya arboleya self-assigned this Sep 20, 2024
@vercel Vercel
Copy link

vercel bot commented Sep 20, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
create-fuels-template ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 20, 2024 7:41pm
ts-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 20, 2024 7:41pm
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
create-fuels-counter-example ⬜️ Ignored (Inspect) Sep 20, 2024 7:41pm

@arboleya arboleya enabled auto-merge (squash) September 20, 2024 19:37
@arboleya arboleya changed the title Aa/chore/adjust logger tests chore: adjust logger tests Sep 20, 2024
@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Sep 20, 2024 •
edited
Loading

CodSpeed Performance Report

Merging #3193 will not alter performance

Comparing aa/chore/adjust-logger-tests (78f884d) with master (8930417)

Summary

✅ 21 untouched benchmarks

maschad
maschad approved these changes Sep 20, 2024
View reviewed changes
Copy link
Member

@maschad maschad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for cleaning this up! 😄

@github-actions GitHub Actions
Copy link
Contributor

Coverage Report:

Lines Branches Functions Statements
77.16%(+0%) 71.81%(+0%) 75.77%(+0%) 77.27%(+0%)
Changed Files:

Coverage values did not change👌.

@arboleya arboleya merged commit ef50619 into master Sep 21, 2024
40 of 43 checks passed
@arboleya arboleya deleted the aa/chore/adjust-logger-tests branch September 21, 2024 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Torres-ssf Torres-ssf Torres-ssf approved these changes

@petertonysmith94 petertonysmith94 petertonysmith94 approved these changes

@maschad maschad maschad approved these changes

@digorithm digorithm Awaiting requested review from digorithm digorithm is a code owner

@Dhaiwat10 Dhaiwat10 Awaiting requested review from Dhaiwat10 Dhaiwat10 is a code owner

@danielbate danielbate Awaiting requested review from danielbate danielbate is a code owner

@nedsalk nedsalk Awaiting requested review from nedsalk nedsalk is a code owner

Assignees

@arboleya arboleya

Labels
chore Issue is a chore
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Logger tests are failing locally
4 participants
@arboleya @maschad @petertonysmith94 @Torres-ssf