-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: fix deprecation on Commander method #3210
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
This PR is published in NPM with version 0.0.0-pr-3210-20240925163330 |
CodSpeed Performance ReportMerging #3210 will degrade performances by 10.36%Comparing Summary
Benchmarks breakdown
|
Dhaiwat10
requested review from
digorithm,
arboleya,
Torres-ssf,
danielbate,
nedsalk,
petertonysmith94 and
maschad
as code owners
September 25, 2024 16:45
arboleya
requested changes
Sep 25, 2024
maschad
approved these changes
Sep 26, 2024
Torres-ssf
approved these changes
Sep 26, 2024
arboleya
approved these changes
Sep 26, 2024
Coverage Report:
Changed Files:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR removes the usage of the
addHelpCommand
method from thecommander
package that we use for our CLIs. We don't need to replace it with anything sincecommander
now automatically adds a help command for your CLI if it has any sub-commands, which our CLIs do.Checklist