Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: reduce flakiness by favoring port 0 over portfinder dependency #3219

Merged
merged 4 commits into from
Sep 27, 2024

Conversation

nedsalk
Copy link
Contributor

@nedsalk nedsalk commented Sep 27, 2024

Summary

This PR replaces the portfinder dependency with the ephemeral port 0 via which the OS is given reins to assign whichever free port it sees fit.

This PR should stop the flakiness that occurs because of trying to start a node on a port that's already in use. I believe that the underlying cause of this is that the free port number given by portfinder gets taken by a different node in some other test before the flaky test's node starts. By using port 0, the real port is only given to the fuel-core node by the OS upon starting of the node, so conflicts like these won't happen.

Checklist

  • All changes are covered by tests (or not applicable)
  • All changes are documented (or not applicable)
  • I reviewed the entire PR myself (preferably, on GH UI)
  • I described all Breaking Changes (or there's none)

@nedsalk nedsalk added bug Issue is a bug chore Issue is a chore labels Sep 27, 2024
@nedsalk nedsalk self-assigned this Sep 27, 2024
Copy link

vercel bot commented Sep 27, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
create-fuels-template ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 27, 2024 11:07am
ts-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 27, 2024 11:07am
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
create-fuels-counter-example ⬜️ Ignored (Inspect) Sep 27, 2024 11:07am

@arboleya arboleya enabled auto-merge (squash) September 27, 2024 10:59
Copy link
Contributor

Coverage Report:

Lines Branches Functions Statements
76.38%(+0%) 71.61%(+0%) 75.49%(+0%) 76.54%(+0%)
Changed Files:

Coverage values did not change👌.

@arboleya arboleya merged commit f02fa88 into master Sep 27, 2024
24 checks passed
@arboleya arboleya deleted the ns/fix/launch-node-test-flakiness branch September 27, 2024 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue is a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants