fix: reduce flakiness by favoring port 0
over portfinder
dependency
#3219
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR replaces the
portfinder
dependency with the ephemeral port0
via which the OS is given reins to assign whichever free port it sees fit.This PR should stop the flakiness that occurs because of trying to start a node on a port that's already in use. I believe that the underlying cause of this is that the free port number given by
portfinder
gets taken by a different node in some other test before the flaky test's node starts. By using port0
, the real port is only given to thefuel-core
node by the OS upon starting of the node, so conflicts like these won't happen.Checklist