Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: provider cache #3278

Merged
merged 34 commits into from
Oct 10, 2024
Merged

Conversation

Torres-ssf
Copy link
Contributor

@Torres-ssf Torres-ssf commented Oct 8, 2024

Release notes

In this release, we:

  • Fixed caching of chain and node data in Provider.

Checklist

  • All changes are covered by tests (or not applicable)
  • All changes are documented (or not applicable)
  • I reviewed the entire PR myself (preferably, on GH UI)
  • I described all Breaking Changes (or there's none)

@Torres-ssf Torres-ssf self-assigned this Oct 8, 2024
Copy link

vercel bot commented Oct 8, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
fuels-template ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 10, 2024 4:05pm
ts-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 10, 2024 4:05pm

@Torres-ssf Torres-ssf changed the title St/chore/remove latest block from chain query chore: remove latestBlock from getChain query Oct 8, 2024
@github-actions github-actions bot added the chore Issue is a chore label Oct 8, 2024
Copy link
Contributor

github-actions bot commented Oct 8, 2024

This PR is published in NPM with version 0.0.0-pr-3278-20241009131606

Copy link

codspeed-hq bot commented Oct 8, 2024

CodSpeed Performance Report

Merging #3278 will not alter performance

Comparing st/chore/remove-latest-block-from-chain-query (26e5f1c) with master (b733e81)

Summary

✅ 18 untouched benchmarks

@arboleya arboleya changed the title chore: remove latestBlock from getChain query fix: provider cache and optimize chain config gql query Oct 8, 2024
…b.com:FuelLabs/fuels-ts into st/chore/remove-latest-block-from-chain-query
@Torres-ssf Torres-ssf changed the title fix: provider cache and optimize chain config gql query fix: provider cache Oct 9, 2024
arboleya
arboleya previously approved these changes Oct 10, 2024
@arboleya arboleya enabled auto-merge (squash) October 10, 2024 15:57
Copy link
Contributor

Coverage Report:

Lines Branches Functions Statements
76.13%(+0.01%) 70.19%(+0%) 75.13%(+0%) 76.25%(+0%)
Changed Files:
Ok File (✨=New File) Lines Branches Functions Statements
🔴 packages/account/src/providers/provider.ts 70.75%
(+0.21%)
64.32%
(+0%)
72.52%
(+0%)
70.41%
(+0.21%)

@arboleya arboleya merged commit 45f4a86 into master Oct 10, 2024
24 checks passed
@arboleya arboleya deleted the st/chore/remove-latest-block-from-chain-query branch October 10, 2024 16:18
Dhaiwat10 pushed a commit that referenced this pull request Nov 19, 2024
* remove latest block from query chain

* release PR

* properly using chain and node cache

* Adding changeset

* fix callstack error

* fix get latest getblock

* fix changeset

Co-authored-by: Anderson Arboleya <anderson@arboleya.me>

* revert changes related to latest block removal

* unrelease PR

* reverting changes

* implement Provider instance clearChainAndNodeCaches

* made static clearChainAndNodeCaches private

* made fetchChainAndNodeInfo to use cached data

* adjusting provider tests

* update transaction upgrade test suite

* add test case

* fixed changeset

* update test case

* revert cache approach

* update tests

* update tests

* adjusting tests

* fix changeset

* adjust test

* update proxy contract factory

* adjusting tests again

* rollback change proxy contract

---------

Co-authored-by: Anderson Arboleya <anderson@arboleya.me>
Co-authored-by: Peter Smith <peter@blueoceancomputing.co.uk>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue is a bug chore Issue is a chore
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Provider cache not working
5 participants