Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: optimize block gql queries #3295

Closed
wants to merge 5 commits into from
Closed

Conversation

Dhaiwat10
Copy link
Member

@Dhaiwat10 Dhaiwat10 commented Oct 9, 2024

Release notes

In this release, we:

  • Optimized block-related GraphQL queries

Summary

This PR updates the GQL schemas so that we only request the data that we are using in the methods to eventually return to the user.

Checklist

  • All changes are covered by tests (or not applicable)
  • All changes are documented (or not applicable)
  • I reviewed the entire PR myself (preferably, on GH UI)
  • I described all Breaking Changes (or there's none)

@Dhaiwat10 Dhaiwat10 self-assigned this Oct 9, 2024
Copy link

vercel bot commented Oct 9, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
fuels-template ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 10, 2024 9:38am
ts-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 10, 2024 9:38am

Copy link

codspeed-hq bot commented Oct 9, 2024

CodSpeed Performance Report

Merging #3295 will degrade performances by 35.75%

Comparing dp/optimize-block-queries (8401df9) with master (55bfa6d)

Summary

❌ 1 regressions
✅ 17 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark master dp/optimize-block-queries Change
should successfully transfer a single asset between wallets (x10 times) 61 ms 95 ms -35.75%

@Dhaiwat10 Dhaiwat10 marked this pull request as draft October 9, 2024 15:14
@nedsalk nedsalk self-requested a review October 9, 2024 15:16
"fuels": patch
---

chore: optimize `block` gql queries
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you mark this as breaking and describe what those are in the PR description?

Copy link
Contributor

Coverage Report:

Lines Branches Functions Statements
76.23%(+0%) 70.3%(+0%) 75.18%(+0%) 76.36%(+0%)
Changed Files:

Coverage values did not change👌.

@petertonysmith94
Copy link
Contributor

petertonysmith94 commented Oct 10, 2024

We deem this PR as not a high priority and will revisit it later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Issue is a chore
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Optimize block's graphql queries
4 participants