Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore!: optimize balance queries #3296

Merged
merged 6 commits into from
Oct 10, 2024
Merged

Conversation

danielbate
Copy link
Contributor

@danielbate danielbate commented Oct 9, 2024

Release notes

In this release, we:

  • Optimised the provider balance queries

Breaking Changes

  • Removed the owner and assetId properties from the response of Provider.operations.getBalance(). These properties are also required arguments to execute the function so are redundant in the response. Should you require these values, you should take them from the values that you passed to the function.
  • Removed the owner property from the response of Provider.operations.getBalances(). This property is a required argument to execute the function so is redundant in the response. Should you require this value, you should take it from the value that you passed to the function.

Checklist

  • All changes are covered by tests (or not applicable)
  • All changes are documented (or not applicable)
  • I reviewed the entire PR myself (preferably, on GH UI)
  • I described all Breaking Changes (or there's none)

Copy link

vercel bot commented Oct 9, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
fuels-template ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 9, 2024 11:52pm
ts-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 9, 2024 11:52pm

@nedsalk nedsalk changed the title chore!: optimise balance queries chore!: optimize balance queries Oct 9, 2024
Copy link

codspeed-hq bot commented Oct 9, 2024

CodSpeed Performance Report

Merging #3296 will not alter performance

Comparing db/chore/optimise-balance-queries (039c993) with master (74991ad)

Summary

✅ 18 untouched benchmarks

Copy link
Contributor

Coverage Report:

Lines Branches Functions Statements
76.18%(+0%) 70.23%(-0.04%) 75.11%(+0%) 76.31%(+0%)
Changed Files:
Ok File (✨=New File) Lines Branches Functions Statements
🔴 packages/account/src/providers/generated/operations.ts 95.03%
(-0.04%)
100%
(+0%)
84.78%
(+0%)
95.45%
(-0.03%)
🔴 packages/account/src/providers/transaction-request/transaction-request.ts 88.57%
(+0%)
76.71%
(-1.37%)
84%
(+0%)
88.81%
(+0%)

@danielbate danielbate merged commit 87da048 into master Oct 10, 2024
24 checks passed
@danielbate danielbate deleted the db/chore/optimise-balance-queries branch October 10, 2024 00:22
Dhaiwat10 pushed a commit that referenced this pull request Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Issue is a chore
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Optimize balances's graphql queries
5 participants