Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix!: remove unnecessary nonce from message gql queries #3298

Merged
merged 11 commits into from
Nov 13, 2024

Conversation

maschad
Copy link
Member

@maschad maschad commented Oct 9, 2024

Release notes

In this release, we:

  • Optimized the getMessageByNonce provider endpoint

Summary

The nonce returned from the gql query was removed from the messageFragment operation as the parameter can actually be re-used in the function getMessageByNonce and a separate fragment was created for getMessage

Breaking Changes

  • Removed the nonce property from Provider.operations.getMessageByNonce(). This can still be retrieved by Provider.getMessageByNonce().

Checklist

  • All changes are covered by tests (or not applicable)
  • All changes are documented (or not applicable)
  • I reviewed the entire PR myself (preferably, on GH UI)
  • I described all Breaking Changes (or there's none)

Copy link

vercel bot commented Oct 9, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
fuels-template ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 12, 2024 10:10am
ts-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 12, 2024 10:10am
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
ts-docs-api ⬜️ Ignored (Inspect) Nov 12, 2024 10:10am

Copy link

codspeed-hq bot commented Oct 9, 2024

CodSpeed Performance Report

Merging #3298 will not alter performance

Comparing mc/fix/optimize-message-gql-queries (24d1a9a) with master (63a34f6)

Summary

✅ 18 untouched benchmarks

@maschad maschad marked this pull request as ready for review October 9, 2024 23:07
danielbate
danielbate previously approved these changes Oct 10, 2024
nedsalk
nedsalk previously approved these changes Oct 10, 2024
packages/account/src/providers/operations.graphql Outdated Show resolved Hide resolved
Co-authored-by: Nedim Salkić <nedim.salkic@fuel.sh>
@maschad maschad dismissed stale reviews from nedsalk and danielbate via 809b0b7 October 10, 2024 13:35
@petertonysmith94
Copy link
Contributor

This can be done at a later date - this optimization doesn't provide (much value).

auto-merge was automatically disabled October 10, 2024 15:15

Pull request was closed

@maschad
Copy link
Member Author

maschad commented Oct 15, 2024

Re-opening this so that we may re-introduce breaking changes at a later more appropriate date.

@maschad maschad reopened this Oct 15, 2024
@maschad maschad marked this pull request as draft October 15, 2024 17:39
@maschad
Copy link
Member Author

maschad commented Oct 15, 2024

Putting this as a draft since it's breaking

@maschad maschad marked this pull request as ready for review November 12, 2024 10:01
Copy link
Contributor

Coverage Report:

Lines Branches Functions Statements
65.18%(+0%) 69.67%(+0%) 73.39%(+0%) 65.6%(+0%)
Changed Files:
Ok File (✨=New File) Lines Branches Functions Statements
🔴 packages/account/src/providers/generated/operations.ts 94.7%
(+0.04%)
100%
(+0%)
84%
(+0%)
95.12%
(+0.03%)

@maschad maschad merged commit f607ba2 into master Nov 13, 2024
25 checks passed
@maschad maschad deleted the mc/fix/optimize-message-gql-queries branch November 13, 2024 02:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue is a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Optimize messages's graphql queries
6 participants