Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore!: made Address toString and valueOf returns checksum #3310

Merged
merged 2 commits into from
Oct 10, 2024

Conversation

Torres-ssf
Copy link
Contributor

@Torres-ssf Torres-ssf commented Oct 10, 2024

Release notes

In this release, we:

  • Made Address.toString and Address.valueOf returns the Address checksum

Breaking Changes

The return of both Address.toString() and Address.valueOf was modified to return the address checksum instead of the Bech32 string

// before
const address = new Address('fuel1elnmzsav56dqnp95sx4e2pckq36cvae9ser44m5zlvgtwxw49fmqd7e42e');

address.toString()
// fuel1elnmzsav56dqnp95sx4e2pckq36cvae9ser44m5zlvgtwxw49fmqd7e42e

address.valueOf()
// fuel1elnmzsav56dqnp95sx4e2pckq36cvae9ser44m5zlvgtwxw49fmqd7e42e
// after
const address = new Address('fuel1elnmzsav56dqnp95sx4e2pckq36cvae9ser44m5zlvgtwxw49fmqd7e42e');

address.toString()
// 0xEf86aFa9696Cf0dc6385e2C407A6e159A1103cEfB7E2Ae0636FB33d3cb2A9E4A

address.valueOf()
// 0xEf86aFa9696Cf0dc6385e2C407A6e159A1103cEfB7E2Ae0636FB33d3cb2A9E4A

Checklist

  • All changes are covered by tests (or not applicable)
  • All changes are documented (or not applicable)
  • I reviewed the entire PR myself (preferably, on GH UI)
  • I described all Breaking Changes (or there's none)

Copy link

vercel bot commented Oct 10, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
fuels-template ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 10, 2024 8:36pm
ts-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 10, 2024 8:36pm

Copy link

codspeed-hq bot commented Oct 10, 2024

CodSpeed Performance Report

Merging #3310 will not alter performance

Comparing st/chore/modify-address-to-string (bfe2edd) with master (f7afa04)

Summary

✅ 18 untouched benchmarks

@Torres-ssf Torres-ssf enabled auto-merge (squash) October 10, 2024 20:52
Copy link
Contributor

Coverage Report:

Lines Branches Functions Statements
76.06%(+0%) 70.01%(+0%) 75.05%(+0%) 76.2%(+0%)
Changed Files:

Coverage values did not change👌.

@Torres-ssf Torres-ssf merged commit bf14023 into master Oct 10, 2024
47 of 48 checks passed
@Torres-ssf Torres-ssf deleted the st/chore/modify-address-to-string branch October 10, 2024 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Issue is a chore
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants