-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: parseUnits
bug with 0 units
#3320
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dhaiwat10
requested review from
digorithm,
arboleya,
Torres-ssf,
danielbate,
nedsalk,
petertonysmith94 and
maschad
as code owners
October 13, 2024 15:49
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
CodSpeed Performance ReportMerging #3320 will improve performances by 17.21%Comparing Summary
Benchmarks breakdown
|
arboleya
reviewed
Oct 13, 2024
Coverage Report:
Changed Files:
|
maschad
approved these changes
Oct 13, 2024
arboleya
approved these changes
Oct 13, 2024
Torres-ssf
approved these changes
Oct 13, 2024
Dhaiwat10
added a commit
that referenced
this pull request
Nov 19, 2024
* fix: `parseUnits` bug with 0 units * add more test cases --------- Co-authored-by: Anderson Arboleya <anderson@arboleya.me>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bn
library bugs parsing when you're using units / precision zero #3316Release notes
In this release, we:
bn.parseUnits
wouldn't work as expected withunits = 0
Summary
This PR fixes a bug in
bn.parseUnits
, as a follow-up of #3300.Checklist