Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: use FuelError instead of JS Error #3329

Merged
merged 2 commits into from
Oct 14, 2024
Merged

chore: use FuelError instead of JS Error #3329

merged 2 commits into from
Oct 14, 2024

Conversation

Torres-ssf
Copy link
Contributor

@Torres-ssf Torres-ssf commented Oct 13, 2024 •
edited
Loading

Checklist

  • All changes are covered by tests (or not applicable)
  • All changes are documented (or not applicable)
  • I reviewed the entire PR myself (preferably, on GH UI)
  • I described all Breaking Changes (or there's none)

@Torres-ssf Torres-ssf self-assigned this Oct 13, 2024
@vercel Vercel
Copy link

vercel bot commented Oct 13, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
fuels-template ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 13, 2024 10:33pm
ts-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 13, 2024 10:33pm

@github-actions github-actions bot added the chore Issue is a chore label Oct 13, 2024
@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Oct 13, 2024 •
edited
Loading

CodSpeed Performance Report

Merging #3329 will not alter performance

Comparing st/chore/use-fuel-error (98fcbb4) with master (bdfd009)

Summary

✅ 18 untouched benchmarks

@github-actions GitHub Actions
Copy link
Contributor

Coverage Report:

Lines Branches Functions Statements
76.07%(+0%) 70.01%(+0%) 75.05%(+0%) 76.2%(+0%)
Changed Files:

Coverage values did not change👌.

@arboleya arboleya merged commit 4ae041e into master Oct 14, 2024
42 of 44 checks passed
@arboleya arboleya deleted the st/chore/use-fuel-error branch October 14, 2024 00:10
@fuel-service-user fuel-service-user mentioned this pull request Oct 14, 2024
Merged
Dhaiwat10 pushed a commit that referenced this pull request Nov 19, 2024
@Torres-ssf @Dhaiwat10
chore: use FuelError instead of JS Error (#3329)
98c5fa0 
* use fuel error instead of common error

* add changeset
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maschad maschad maschad approved these changes

@arboleya arboleya arboleya approved these changes

@digorithm digorithm Awaiting requested review from digorithm digorithm is a code owner

@Dhaiwat10 Dhaiwat10 Awaiting requested review from Dhaiwat10 Dhaiwat10 is a code owner

@danielbate danielbate Awaiting requested review from danielbate danielbate is a code owner

@nedsalk nedsalk Awaiting requested review from nedsalk nedsalk is a code owner

@petertonysmith94 petertonysmith94 Awaiting requested review from petertonysmith94 petertonysmith94 is a code owner

Assignees

@Torres-ssf Torres-ssf

Labels
chore Issue is a chore
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Torres-ssf @arboleya @maschad