-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore!: refactor predicate and script deployment #3389
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
CodSpeed Performance ReportMerging #3389 will not alter performanceComparing Summary
|
6d5bb18
to
c25eddc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job on this @nedsalk 👏
16d9504
Great work @nedsalk, looks like there is a signficant drop in the coverage for some of the files - specifically |
@Dhaiwat10 good catch! It's because the file is not used anymore given that the logic was moved to another place. I have removed it in 3504151. |
Coverage Report:
Changed Files:
|
ContractFactory
#3361Summary
Moves predicate and script deployment from
ContractFactory
to their respective classes as adeploy
instance method.Breaking Changes
ContractFactory.deployAsBlobTxForScript
has been removed in favor ofPredicate.deploy
andScript.deploy
:Checklist