feat: better typegen contract factory integration with launchTestNode
#3398
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nedsalk
requested review from
digorithm,
arboleya,
Torres-ssf,
Dhaiwat10,
danielbate,
petertonysmith94 and
maschad
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
…-node-contract-factory-integration
CodSpeed Performance ReportMerging #3398 will not alter performanceComparing Summary
|
nedsalk
force-pushed
the
ns/feat/launch-test-node-contract-factory-integration
branch
from
db16ebc to
8f61ca9
Compare
Torres-ssf
previously approved these changes
Nov 15, 2024
Torres-ssf
approved these changes
Nov 18, 2024
petertonysmith94
approved these changes
Nov 18, 2024
|
Coverage Report:
Changed Files:
|
maschad
deleted the
ns/feat/launch-test-node-contract-factory-integration
branch
nedsalk
added a commit
that referenced
this pull request
Nov 20, 2024
…e` (#3398) * feat: better typegen contract factory integration with `launchTestNode` * give name to type * remove type assertion to improve inference * update docs to new approach * changeset * revert unnecessary change * rerun workflows * revert change * give name to intermediary type --------- Co-authored-by: Chad Nehemiah <chad.nehemiah94@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
launchTestNodeintegration withtypegencontract factories #2708In this release, we:
launchTestNodeand typegen'd contract factories integrationSummary
With this PR we can now pass in the typegen'd contract factory directly instead of having to wrap it in a
{ factory: TypegendContractFactory }object.Checklist