fix: transferToContract method now allows big numbers
#3458
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
petertonysmith94
changed the title
transferToContract method now allows big numbers
CodSpeed Performance ReportMerging #3458 will not alter performanceComparing Summary
|
petertonysmith94
requested review from
digorithm,
arboleya,
Torres-ssf,
Dhaiwat10,
danielbate,
nedsalk and
maschad
as code owners
Dhaiwat10
reviewed
Dec 9, 2024
|
Coverage Report:
Changed Files:Coverage values did not change👌. |
danielbate
reviewed
Dec 9, 2024
danielbate
approved these changes
Dec 9, 2024
Torres-ssf
approved these changes
Dec 9, 2024
arboleya
approved these changes
Dec 9, 2024
starc007
pushed a commit
to starc007/fuels-ts
that referenced
this pull request
Dec 9, 2024
* fix: incorrectly converting BN to number for `formatTransferToContractScriptData` * chore: changeset * chore: tests * chore: added test for batch transfer
petertonysmith94
added a commit
that referenced
this pull request
Dec 10, 2024
* feat: integrate vitest matchers globally * fix: added global type file & changed setup file directory * docs: improve `cookbook/transaction-request` (#3440) * chore: silence recipes format logs (#3451) * chore: silence recipe logs * chore: update changeset * docs: fix api links (#3452) * docs: fixing API links * chore: fixing relative links * fix: `transferToContract` method now allows big numbers (#3458) * fix: incorrectly converting BN to number for `formatTransferToContractScriptData` * chore: changeset * chore: tests * chore: added test for batch transfer * fix: moved vitest matcher setup from fuel-gauge to utils * fix(utils): update vitest matcher import path * chore: add changeset for vitest matcher changes * fix: removed previous changeset * chore: removed types * chore: added changeset * Update .changeset/rare-hornets-rush.md --------- Co-authored-by: Sérgio Torres <30977845+Torres-ssf@users.noreply.github.com> Co-authored-by: Daniel Bate <djbate23@gmail.com> Co-authored-by: Peter Smith <peter@blueoceancomputing.co.uk>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release notes
In this release, we:
transferToContractandbatchTransferToContractsto accept big number amounts.Checklist