Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: release deprecation script #3465

Merged
merged 11 commits into from
Dec 12, 2024
Merged

Conversation

danielbate
Copy link
Contributor

@danielbate danielbate commented Dec 11, 2024

Summary

This PR adds a new release deprecation workflow, that will clean up our pnpm info fuels result. Unfortunately, we are unable to unpublish so this is the next best. In a follow up, I will provide a solution to mitigate future PR versions.

Checklist

  • All changes are covered by tests (or not applicable)
  • All changes are documented (or not applicable)
  • I reviewed the entire PR myself (preferably, on GH UI)
  • I described all Breaking Changes (or there's none)

@danielbate danielbate added the chore Issue is a chore label Dec 11, 2024
@danielbate danielbate self-assigned this Dec 11, 2024
Copy link

vercel bot commented Dec 11, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
fuels-template ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 12, 2024 11:16am
ts-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 12, 2024 11:16am
ts-docs-api ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 12, 2024 11:16am

Copy link

codspeed-hq bot commented Dec 11, 2024

CodSpeed Performance Report

Merging #3465 will improve performances by 83.41%

Comparing db/chore/release-deprecation (d0d1537) with master (ebe5ecd)

Summary

⚡ 1 improvements
✅ 17 untouched benchmarks

Benchmarks breakdown

Benchmark master db/chore/release-deprecation Change
should successfully conduct a custom transfer between wallets (x20 times) 91.7 ms 50 ms +83.41%

.github/workflows/release-deprecate.yaml Show resolved Hide resolved
scripts/release-deprecate.ts Outdated Show resolved Hide resolved
scripts/release-deprecate.ts Outdated Show resolved Hide resolved
scripts/release-deprecate.ts Show resolved Hide resolved
Copy link
Member

@maschad maschad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good but just have two questions

scripts/release-deprecate.ts Show resolved Hide resolved
scripts/release-deprecate.ts Outdated Show resolved Hide resolved
Copy link
Contributor

Coverage Report:

Lines Branches Functions Statements
76.33%(+0%) 69.8%(-0.04%) 74.2%(+0%) 76.34%(+0%)
Changed Files:
Ok File (✨=New File) Lines Branches Functions Statements
🔴 packages/account/src/providers/transaction-request/transaction-request.ts 88.57%
(+0%)
76.71%
(-1.37%)
84%
(+0%)
88.81%
(+0%)

@danielbate danielbate merged commit 3a067c6 into master Dec 12, 2024
25 checks passed
@danielbate danielbate deleted the db/chore/release-deprecation branch December 12, 2024 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Issue is a chore
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants