Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: specify versions in create fuels toolchain file #3475

Merged
merged 7 commits into from
Dec 13, 2024

Conversation

Dhaiwat10
Copy link
Member

@Dhaiwat10 Dhaiwat10 commented Dec 12, 2024

Summary

This PR fixes the 'deploying to testnet' guide not working as expected for new users by specifying versions for forc and fuel-core in the toolchain files used by create fuels projects. This fixes this error for users with fresh fuelup installations, and also people who may have never installed or used the testnet toolchain channel:

> forc deploy --testnet

component 'forc-deploy' not found in currently active toolchain 'testnet-aarch64-apple-darwin'

This change fixes the problem because the testnet channel does not come with the forc-deploy plugin included by default when you specified in a toolchain file. This is not ideal behaviour, but will have to do for now. Specifying the versions for forc and fuel-core includes the necessary plugin and fixes things.

Checklist

  • All changes are covered by tests (or not applicable)
  • All changes are documented (or not applicable)
  • I reviewed the entire PR myself (preferably, on GH UI)
  • I described all Breaking Changes (or there's none)

@Dhaiwat10 Dhaiwat10 added the bug Issue is a bug label Dec 12, 2024
@Dhaiwat10 Dhaiwat10 self-assigned this Dec 12, 2024
Copy link

vercel bot commented Dec 12, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
fuels-template ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 13, 2024 2:26pm
ts-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 13, 2024 2:26pm
ts-docs-api ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 13, 2024 2:26pm

Copy link
Contributor

github-actions bot commented Dec 12, 2024

This PR is published in NPM with version 0.0.0-pr-3475-20241212204104

Copy link

codspeed-hq bot commented Dec 12, 2024

CodSpeed Performance Report

Merging #3475 will improve performances by 53.33%

Comparing dp/fix-create-fuels-toolchain (07c3c25) with master (5ec254d)

Summary

⚡ 1 improvements
✅ 17 untouched benchmarks

Benchmarks breakdown

Benchmark master dp/fix-create-fuels-toolchain Change
should successfully conduct a custom transfer between wallets (x20 times) 96.2 ms 62.8 ms +53.33%

@Dhaiwat10 Dhaiwat10 changed the title fix: use latest toolchain channel for create fuels fix: specify versions in create fuels toolchain file Dec 12, 2024
danielbate
danielbate previously approved these changes Dec 13, 2024
arboleya
arboleya previously approved these changes Dec 13, 2024
@Dhaiwat10 Dhaiwat10 dismissed stale reviews from arboleya and danielbate via 07c3c25 December 13, 2024 14:18
@petertonysmith94 petertonysmith94 enabled auto-merge (squash) December 13, 2024 14:36
Copy link
Contributor

Coverage Report:

Lines Branches Functions Statements
76.33%(+0%) 69.84%(+0%) 74.2%(+0%) 76.34%(+0%)
Changed Files:

Coverage values did not change👌.

@petertonysmith94 petertonysmith94 merged commit efdf9a1 into master Dec 13, 2024
31 checks passed
@petertonysmith94 petertonysmith94 deleted the dp/fix-create-fuels-toolchain branch December 13, 2024 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue is a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

'Deploying to testnet' guide doesn't work for new users
4 participants