docs: segregate api docs url/deployment #3602
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
nedsalk
commented
Jan 30, 2025
| VERCEL_PROJECT_ID: ${{ secrets.VERCEL_TS_DOCS_API_PROJECT_ID }} | ||
| run: | | ||
| pnpm install --global vercel@latest | ||
| vercel --prod --token=${{ secrets.VERCEL_TOKEN }} |
There was a problem hiding this comment.
@arboleya we'll need to add all these secrets to the repo. When we get to supporting multiple LTS versions and all that, this same idea would remain, maybe just modified a bit (or maybe not, depending on how we implement it).
There was a problem hiding this comment.
For env/secrets, please check it with @mchristopher.
There was a problem hiding this comment.
@luizstacio can you help here? I don't have Vercel access
petertonysmith94
previously approved these changes
Feb 6, 2025
danielbate
previously approved these changes
Feb 7, 2025
nedsalk
dismissed stale reviews from danielbate and petertonysmith94
via
9f08324
danielbate
approved these changes
Feb 7, 2025
petertonysmith94
approved these changes
Feb 7, 2025
Torres-ssf
approved these changes
Feb 7, 2025
arboleya
approved these changes
Feb 7, 2025
|
Coverage Report:
Changed Files:Coverage values did not change👌. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR contains the implementation detailed in #3572 (comment).
Once this PR is merged, we should disable the automatic triggering of the docs-api production environment as it'll be reserved for the release workflow to trigger. The nightly environment is being updated on every merge.
Note
When testing out the docs preview of this PR to see if the API is linked properly, opens up a new tab, etc, it might not open up a new tab. Please clear the browser cache and try clicking on the links again.
The related docs-hub PR is
and should be merged before this one to verify that everything works.
Checklist