Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: favour .ts over .d.ts files in @fuel-ts/abi-typegen #3680

Merged
merged 9 commits into from
Feb 10, 2025
Merged

fix: favour .ts over .d.ts files in @fuel-ts/abi-typegen #3680

merged 9 commits into from
Feb 10, 2025

Conversation

petertonysmith94
Copy link
Contributor

Summary

  • The .d.ts files don't get bundled into the final distribution for @fuel-ts/recipes. This change will rename all .d.ts files to .ts before building the package out for distribution.
Before After
Screenshot 2025-02-07 at 16 34 41 image

Checklist

  • All changes are covered by tests (or not applicable)
  • All changes are documented (or not applicable)
  • I reviewed the entire PR myself (preferably, on GH UI)
  • I described all Breaking Changes (or there's none)

@petertonysmith94 petertonysmith94 added bug Issue is a bug chore Issue is a chore labels Feb 7, 2025
@petertonysmith94 petertonysmith94 self-assigned this Feb 7, 2025
@vercel Vercel
Copy link

vercel bot commented Feb 7, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
fuels-template ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 10, 2025 8:58am
ts-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 10, 2025 8:58am
ts-docs-api ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 10, 2025 8:58am

@petertonysmith94 petertonysmith94 removed the chore Issue is a chore label Feb 7, 2025
@petertonysmith94 petertonysmith94 marked this pull request as ready for review February 7, 2025 17:48
@arboleya arboleya mentioned this pull request Feb 7, 2025
Open
@petertonysmith94 petertonysmith94 changed the title fix: correctly bundle @fuel-ts/recipes files fix: favour .ts over .d.ts files in @fuel-ts/abi-typegen Feb 10, 2025
arboleya
arboleya approved these changes Feb 10, 2025
View reviewed changes
Copy link
Member

@arboleya arboleya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎯

@github-actions GitHub Actions
Copy link
Contributor

Coverage Report:

Lines Branches Functions Statements
77.15%(+0%) 70.69%(+0%) 75.3%(+0%) 77.15%(+0%)
Changed Files:

Coverage values did not change👌.

@petertonysmith94 petertonysmith94 merged commit 6f32228 into master Feb 10, 2025
25 checks passed
@petertonysmith94 petertonysmith94 deleted the ps/chore/fix-incorrect-recipe-bundling branch February 10, 2025 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arboleya arboleya arboleya approved these changes

@danielbate danielbate danielbate approved these changes

@nedsalk nedsalk nedsalk approved these changes

@digorithm digorithm Awaiting requested review from digorithm digorithm is a code owner

@Torres-ssf Torres-ssf Awaiting requested review from Torres-ssf Torres-ssf is a code owner

Assignees

@petertonysmith94 petertonysmith94

Labels
bug Issue is a bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@petertonysmith94 @arboleya @danielbate @nedsalk