Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: contract operations in transaction summary #3704

Merged
merged 11 commits into from
Feb 14, 2025

Conversation

danielbate
Copy link
Member

@danielbate danielbate commented Feb 12, 2025

Release notes

In this release, we:

  • Introduced decodeScriptData to decode contract operations from a call receipt
  • Fixed contract operations in transaction summaries

Summary

  • Uses the raw payload for a transaction to obtain it's script data, and uses that to decode the contract operations rather than using param1/param2 in the call receipt
  • Introduces the decodeScriptData function to directly decode the bytes from a contract call script

Checklist

  • All changes are covered by tests (or not applicable)
  • All changes are documented (or not applicable)
  • I reviewed the entire PR myself (preferably, on GH UI)
  • I described all Breaking Changes (or there's none)

@danielbate danielbate added the bug Issue is a bug label Feb 12, 2025
@danielbate danielbate self-assigned this Feb 12, 2025
Copy link

vercel bot commented Feb 12, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
fuels-template ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 14, 2025 1:05pm
ts-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 14, 2025 1:05pm
ts-docs-api ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 14, 2025 1:05pm

Torres-ssf
Torres-ssf previously approved these changes Feb 12, 2025
Co-authored-by: Peter Smith <peter@blueoceancomputing.co.uk>
@danielbate danielbate changed the title fix!: contract operations in transaction summary fix: contract operations in transaction summary Feb 13, 2025
@danielbate danielbate marked this pull request as draft February 13, 2025 10:45
arboleya
arboleya previously approved these changes Feb 14, 2025
Torres-ssf
Torres-ssf previously approved these changes Feb 14, 2025
Copy link
Contributor

Coverage Report:

Lines Branches Functions Statements
77.12%(-0.03%) 70.79%(+0.1%) 75.27%(-0.03%) 77.12%(-0.03%)
Changed Files:
Ok File (✨=New File) Lines Branches Functions Statements
🔴 ✨ packages/abi-coder/src/utils/scriptData.ts 0%
(+0%)
0%
(+0%)
0%
(+0%)
0%
(+0%)
🔴 packages/account/src/providers/provider.ts 67.53%
(+0.58%)
59.8%
(+2.73%)
68.04%
(+0%)
67.29%
(+0.56%)
🔴 packages/errors/src/test-utils/expect-to-throw-fuel-error.ts 91.66%
(-0.34%)
88.88%
(+0%)
100%
(+0%)
91.66%
(-0.34%)

Copy link
Contributor

@petertonysmith94 petertonysmith94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

@danielbate danielbate merged commit 194e31f into master Feb 14, 2025
25 checks passed
@danielbate danielbate deleted the db/fix/summary-contract-ops branch February 14, 2025 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue is a bug
Projects
None yet
5 participants