-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: refactor predicate support to work through Wallet and Provider directly #461
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Total Coverage: 89.80% Coverage Report
|
luizstacio
approved these changes
Aug 18, 2022
LuizAsFight
approved these changes
Aug 19, 2022
camsjams
pushed a commit
that referenced
this pull request
Aug 22, 2022
* Rebase * Refactor * Adjust usage of address * Update deps * Adjust wallet test * Fix comparison * Update predicate usage * Add to contract * adjust contract * Add util * Add helper * Update wallet manager * Cleanup * Update contract tweaks * add CS * Use AbstractAddress * Fix address usage * Fix generated types and usage * Update test * revert * tired of this lint * Refactor * use static helpers and new method names * refactor to make encoding transparent * relocate into helper * Lint * Enforce type stronger * Adjust test * fix lint * feat!: refactor predicate support to work through Wallet and Provider directly (#461) relocate predicate related helpers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #392
This moves
Predicates
much closer to a streamlined approach. If using aWallet
, a developer can then leverage the wallet's address and coin information when interacting with Predicates, both in creation and spending.If using a Predicate that has fees already pre-paid, developers can work through the
Provider
directly with the receiver address of their choice.