Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add toJSON to Address Class #502

Merged
merged 3 commits into from
Sep 9, 2022
Merged

feat: add toJSON to Address Class #502

merged 3 commits into from
Sep 9, 2022

Conversation

luizstacio
Copy link
Member

Add toJSON for parsing values to bech32 when using JSON.stringify with Address object

@luizstacio luizstacio self-assigned this Sep 9, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Sep 9, 2022 •
edited
Loading

Coverage report

St.❔
 Category Percentage Covered / Total
🟢 Statements 89.97% 3220/3579
🟡 Branches 70.3% 594/845
🟢 Functions 87.06% 646/742
🟢 Lines 89.82% 3087/3437

Test suite run success

487 tests passing in 44 suites.

Report generated by 🧪jest coverage report action from d6be423

camsjams
camsjams approved these changes Sep 9, 2022
View reviewed changes
Copy link
Contributor

@camsjams camsjams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice find!

@luizstacio luizstacio enabled auto-merge (squash) September 9, 2022 18:09
@luizstacio luizstacio merged commit 5828934 into master Sep 9, 2022
@luizstacio luizstacio deleted the ls/address-to-json branch September 9, 2022 18:17
@github-actions github-actions bot mentioned this pull request Sep 9, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@QuinnLee QuinnLee QuinnLee approved these changes

@camsjams camsjams camsjams approved these changes

@LuizAsFight LuizAsFight Awaiting requested review from LuizAsFight

Assignees

@luizstacio luizstacio

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@luizstacio @camsjams @QuinnLee