feat: add vaultId to accounts
#505
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coverage report
Test suite run success503 tests passing in 44 suites. Report generated by 🧪jest coverage report action from 6b3bff3 |
QuinnLee
commented
Sep 12, 2022
Comment on lines
5
to
+8
| export type Account = { | ||
| address: AbstractAddress; | ||
| publicKey: string; | ||
| vaultId?: number; |
There was a problem hiding this comment.
Not sure if this is desired. Alternative is Array<Account & { vaultId?: number }> on getAccounts
There was a problem hiding this comment.
I think is ok, as Account is already a high level type for the wallet manager
luizstacio
approved these changes
Sep 12, 2022
camsjams
approved these changes
Sep 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TLDR
Added
vaultIdon the accounts!