Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: fix auto-doc-generation pnpm wrapper #556

Merged
merged 3 commits into from
Oct 29, 2022
Merged

feat: fix auto-doc-generation pnpm wrapper #556

merged 3 commits into from
Oct 29, 2022

Conversation

camsjams
Copy link
Contributor

Follow-up to #533 and #123

Some of the late changes in this PR caused a bug.

@camsjams camsjams self-assigned this Oct 28, 2022
@camsjams camsjams requested a review from a team October 28, 2022 06:26
@github-actions
Copy link
Contributor

github-actions bot commented Oct 28, 2022

Coverage report

St.
Category Percentage Covered / Total
🟢 Statements 89.29% 3500/3920
🟡 Branches 70.74% 677/957
🟢 Functions 86.65% 701/809
🟢 Lines 89.23% 3347/3751

Test suite run success

527 tests passing in 47 suites.

Report generated by 🧪jest coverage report action from 8069eda

@arboleya
Copy link
Member

I upgraded the packages typedoc and typedoc-plugin-markdown via:

Couldn't we adjust things and use their latest versions?

Or is downgrading our only option?

@camsjams camsjams enabled auto-merge (squash) October 29, 2022 18:31
@camsjams
Copy link
Contributor Author

I upgraded the packages typedoc and typedoc-plugin-markdown via:

Couldn't we adjust things and use their latest versions?

Or is downgrading our only option?

There was a breaking change in typedoc that caused the plug-in to break, I can see if they've patched it

@camsjams camsjams merged commit 9b1eeeb into master Oct 29, 2022
@camsjams camsjams deleted the cm/fix-docs branch October 29, 2022 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants