Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: add support for the messageout receipt type #558

Merged
merged 3 commits into from
Oct 29, 2022
Merged

refactor: add support for the messageout receipt type #558

merged 3 commits into from
Oct 29, 2022

Conversation

pixelcircuits
Copy link
Contributor

Filled in spec gap for the MessageOut receipt type

@pixelcircuits pixelcircuits added docs Requests pertinent to documentation package:transactions labels Oct 28, 2022
@pixelcircuits pixelcircuits self-assigned this Oct 28, 2022
@pixelcircuits pixelcircuits linked an issue Oct 28, 2022 that may be closed by this pull request
Add support for the MessageOut receipt type #555
Closed
@luizstacio
Copy link
Member

Docs are auto-generated on changesets PR, @pixelcircuits you can remove the files on your PR.

@github-actions
Copy link
Contributor

Coverage report

St.❔
 Category Percentage Covered / Total
🟢 Statements
89.29% (+0.11% 🔼)
 3500/3920
🟡 Branches
70.74% (+0.22% 🔼)
 677/957
🟢 Functions
86.65% (+0.19% 🔼)
 701/809
🟢 Lines
89.23% (+0.11% 🔼)
 3347/3751

Test suite run success

527 tests passing in 47 suites.

Report generated by 🧪jest coverage report action from 966740b

luizstacio
luizstacio approved these changes Oct 28, 2022
View reviewed changes
Copy link
Member

@luizstacio luizstacio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pixelcircuits
Copy link
Contributor Author

Docs are auto-generated on changesets PR, @pixelcircuits you can remove the files on your PR.

So do we need to update the docs for contributing?

@luizstacio luizstacio requested a review from arboleya October 28, 2022 19:10
digorithm
digorithm approved these changes Oct 29, 2022
View reviewed changes
Copy link
Member

@digorithm digorithm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very clean refactor, many thanks @pixelcircuits!

@luizstacio luizstacio merged commit eebb0bd into master Oct 29, 2022
@luizstacio luizstacio deleted the 555-add-support-for-the-messageout-receipt-type branch October 29, 2022 18:12
@github-actions github-actions bot mentioned this pull request Oct 29, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@luizstacio luizstacio luizstacio approved these changes

@digorithm digorithm digorithm approved these changes

@AlicanC AlicanC Awaiting requested review from AlicanC

@camsjams camsjams Awaiting requested review from camsjams

@LuizAsFight LuizAsFight Awaiting requested review from LuizAsFight

@arboleya arboleya Awaiting requested review from arboleya arboleya is a code owner

Assignees

@pixelcircuits pixelcircuits

Labels
docs Requests pertinent to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support for the MessageOut receipt type
3 participants
@pixelcircuits @luizstacio @digorithm