Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: minPrecision overiding valid digits inside precision range #573

Merged
merged 3 commits into from
Nov 2, 2022

Conversation

LuizAsFight
Copy link
Contributor

fix bug that would make this test fail:

    expect(
      bn('100100020000').format({
        minPrecision: 4,
        precision: 8,
      })
    ).toEqual('100.10002');

Closes #572

@github-actions
Copy link
Contributor

github-actions bot commented Nov 1, 2022

Coverage report

St.
Category Percentage Covered / Total
🟢 Statements 90.2% 3597/3988
🟡 Branches 72.77% 700/962
🟢 Functions 87.82% 721/821
🟢 Lines 90.21% 3447/3821

Test suite run success

543 tests passing in 49 suites.

Report generated by 🧪jest coverage report action from d8c29fe

@LuizAsFight LuizAsFight merged commit ec83b17 into master Nov 2, 2022
@LuizAsFight LuizAsFight deleted the lf-572/fix/bn-format-precision branch November 2, 2022 05:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bn.format not respecting precision config
4 participants