Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: include gas/fee info and decoded transaction in TransactionResponse #587

Merged
merged 6 commits into from
Nov 10, 2022

Conversation

LuizAsFight
Copy link
Contributor

@LuizAsFight LuizAsFight commented Nov 9, 2022

  • Include already calculated gas/fee info in TransactionResponse
  • Include decoded transaction in TransactionResponse
  • Remove need of TransactionRequest in TransactionResponse, because it doesn't make sense to need to know the Request, when you only want the response. Response should be gettable only with transactionId in hands
  • Fix a bug decoding predicate inputs from transaction

@github-actions
Copy link
Contributor

github-actions bot commented Nov 9, 2022

Coverage report

St.
Category Percentage Covered / Total
🟢 Statements
90.23% (+0.26% 🔼)
3638/4032
🟡 Branches
71.53% (-0.76% 🔻)
701/980
🟢 Functions
86.79% (-0.59% 🔻)
723/833
🟢 Lines
90.26% (+0.27% 🔼)
3485/3861
Show files with reduced coverage 🔻
St.
File Statements Branches Functions Lines
🟡
... / provider.ts
73.65% (-0.16% 🔻)
62.5% 73.81%
72.33% (-0.17% 🔻)
🟢
... / transaction-response.ts
82.5% (-2.12% 🔻)
55.56% 100%
82.5% (-2.12% 🔻)
🟡
... / script.ts
75.86% (-6.9% 🔻)
28.57% (-28.57% 🔻)
83.33%
75.86% (-6.9% 🔻)
🔴
... / errors.ts
30% (-55% 🔻)
0% (-43.75% 🔻)
0% (-62.5% 🔻)
30% (-55% 🔻)
🔴 script/src/utils.ts
44.44% (-22.22% 🔻)
0%
0% (-50% 🔻)
37.5% (-25% 🔻)

Test suite run success

545 tests passing in 49 suites.

Report generated by 🧪jest coverage report action from 4404019

@LuizAsFight LuizAsFight changed the title feat: include gas/fee info in TransactionResponse feat: include gas/fee info and decoded transaction in TransactionResponse Nov 10, 2022
@LuizAsFight LuizAsFight marked this pull request as ready for review November 10, 2022 01:54
@LuizAsFight LuizAsFight merged commit eaa3549 into master Nov 10, 2022
@LuizAsFight LuizAsFight deleted the lf/feat/response-fee branch November 10, 2022 02:07
@LuizAsFight LuizAsFight self-assigned this Sep 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants