Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add vector as output slice #812

Merged
merged 10 commits into from
Mar 10, 2023
Merged

feat: add vector as output slice #812

merged 10 commits into from
Mar 10, 2023

Conversation

camsjams
Copy link
Contributor

@camsjams camsjams commented Mar 5, 2023

Closes #487

@camsjams camsjams self-assigned this Mar 5, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Mar 5, 2023 •
edited
Loading

Coverage report

St.❔
 Category Percentage Covered / Total
🟢 Statements
94.99% (+0.05% 🔼)
 4551/4791
🟢 Branches
83.52% (+0.58% 🔼)
 816/977
🟢 Functions 92% 885/962
🟢 Lines
94.88% (+0.05% 🔼)
 4372/4608

Test suite run success

760 tests passing in 109 suites.

Report generated by 🧪jest coverage report action from 52bd3cd

@camsjams camsjams requested review from a team, arboleya, Dhaiwat10 and Torres-ssf March 6, 2023 16:27
@camsjams camsjams marked this pull request as ready for review March 6, 2023 16:27
Torres-ssf
Torres-ssf previously approved these changes Mar 7, 2023
View reviewed changes
Dhaiwat10
Dhaiwat10 previously approved these changes Mar 8, 2023
View reviewed changes
@camsjams camsjams dismissed stale reviews from Dhaiwat10 and Torres-ssf via 4d6f4aa March 9, 2023 17:40
arboleya
arboleya previously approved these changes Mar 9, 2023
View reviewed changes
Copy link
Member

@arboleya arboleya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Succinct. 🎯 👏

packages/abi-coder/src/abi-coder.ts Outdated Show resolved Hide resolved
Torres-ssf
Torres-ssf previously approved these changes Mar 9, 2023
View reviewed changes
Dhaiwat10
Dhaiwat10 previously approved these changes Mar 10, 2023
View reviewed changes
Copy link
Member

@Dhaiwat10 Dhaiwat10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good apart from that one lint warning!

@camsjams camsjams dismissed stale reviews from Dhaiwat10 and Torres-ssf via 52bd3cd March 10, 2023 19:12
@camsjams camsjams enabled auto-merge (squash) March 10, 2023 19:20
@camsjams camsjams requested review from arboleya, Torres-ssf, Dhaiwat10 and a team March 10, 2023 19:34
@camsjams camsjams merged commit dd7b1ca into master Mar 10, 2023
@camsjams camsjams deleted the cm/issue-487-v2 branch March 10, 2023 20:59
@github-actions github-actions bot mentioned this pull request Mar 10, 2023
Merged
@digorithm digorithm mentioned this pull request Apr 20, 2023
Closed
@camsjams camsjams mentioned this pull request May 3, 2023
Closed
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@luizstacio luizstacio luizstacio approved these changes

@arboleya arboleya arboleya approved these changes

@Torres-ssf Torres-ssf Awaiting requested review from Torres-ssf Torres-ssf is a code owner

@Dhaiwat10 Dhaiwat10 Awaiting requested review from Dhaiwat10 Dhaiwat10 is a code owner

Assignees

@camsjams camsjams

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Vec<T> Support as an Output
5 participants
@camsjams @arboleya @luizstacio @Torres-ssf @Dhaiwat10