Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update connectors ui #972

Merged
merged 13 commits into from
Nov 20, 2023
Merged

feat: update connectors ui #972

merged 13 commits into from
Nov 20, 2023

Conversation

luizstacio
Copy link
Member

@luizstacio luizstacio commented Nov 14, 2023

Update Connectors UI on the react package to work without fuel-ui dependencies.

In this PR;

  • Update Connectors UI to work without fuel-ui
  • For better portability, I have chosen to;
    • Add styled-components for adding styling. The approach was selected to avoid page CSS to affect the SDK UI.
    • All icons are created using JSX components instead of the path approach.
    • Add CSS vars for enabling theming. This allows applications to change colors and spacing.
    • To allow better customization with fewer variables, all spacing and margins are based on em taking the font-size of the root container as a reference.
  • Fix some of the compatibility issues for the new SDK approach.
  • Create an Example Application using CRA. This will be useful for the documentation and help communicate how to implement a DApp.
  • Fix E2E tests to work with the new Connectors UI. In this way, we have at least some coverage of it. Previously, we didn't have tests covering this specific component.
  • Add exports on the package.json of the react package. This is a pain in development as it now requires the package to be built before use, but it is the only way to ensure the correct packing of the UI to test it.

Kwon issues;

  • Documentation needs to be updated and will be improved on the next PR.
  • Some of the documentation can be broken also.

Next Steps;

  • Work on the documentation;
  • Integrate the current Connectors UI on the Fuel Bridge.
example-app.mov

closes FE-8

@luizstacio luizstacio changed the base branch from master to sdk-v2 November 14, 2023 19:43
Copy link

linear bot commented Nov 14, 2023

FE-8 Fuel Connector V2 -> Light Weight UI

To enable people to use our connector UI, it is required that the UI is very light and does not have dependencies on external—UI libraries.

For this task, we should update the current UI using fuel-ui to use plain CSS but following the same design we already have.

Copy link
Contributor

github-actions bot commented Nov 14, 2023

Coverage report for ./packages/app

St.
Category Percentage Covered / Total
🟡 Statements 67.67% 3383/4999
🔴 Branches 44.52% 618/1388
🔴 Functions 51.25% 716/1397
🟡 Lines 68.24% 3259/4776

Test suite run success

241 tests passing in 73 suites.

Report generated by 🧪jest coverage report action from d0c1d9b

@luizstacio luizstacio merged commit 1652c1d into sdk-v2 Nov 20, 2023
12 checks passed
@luizstacio luizstacio deleted the ls/feat/update-connectors-ui branch November 20, 2023 15:54
luizstacio added a commit that referenced this pull request Jan 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants