-
Notifications
You must be signed in to change notification settings - Fork 418
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: update connectors ui #972
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FE-8 Fuel Connector V2 -> Light Weight UI
To enable people to use our connector UI, it is required that the UI is very light and does not have dependencies on external—UI libraries. For this task, we should update the current UI using fuel-ui to use plain CSS but following the same design we already have. |
Coverage report for
|
St.❔ |
Category | Percentage | Covered / Total |
---|---|---|---|
🟡 | Statements | 67.67% | 3383/4999 |
🔴 | Branches | 44.52% | 618/1388 |
🔴 | Functions | 51.25% | 716/1397 |
🟡 | Lines | 68.24% | 3259/4776 |
Test suite run success
241 tests passing in 73 suites.
Report generated by 🧪jest coverage report action from d0c1d9b
luizstacio
requested review from
pedronauck,
LuizAsFight,
matt-user and
sarahschwartz
as code owners
November 15, 2023 03:06
LuizAsFight
approved these changes
Nov 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update Connectors UI on the react package to work without fuel-ui dependencies.
In this PR;
em
taking thefont-size
of the root container as a reference.exports
on the package.json of the react package. This is a pain in development as it now requires the package to be built before use, but it is the only way to ensure the correct packing of the UI to test it.Kwon issues;
Next Steps;
example-app.mov
closes FE-8