Bump all applications #793
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
matt-user
reviewed
May 28, 2024
bitzoic
previously approved these changes
May 29, 2024
|
|
||
| mint(&instance_1, other_identity, sub_id_1, 1).await; | ||
|
|
||
| let call_params = CallParameters::new(1, BASE_ASSET_ID, 1_000_000); | ||
| let call_params = CallParameters::new(1, AssetId::zeroed(), 1_000_000); |
There was a problem hiding this comment.
Please create an issue that this should be provider.base_asset_id() instead. There are a few instances throughout the tests this is used
matt-user
previously approved these changes
May 29, 2024
matt-user
approved these changes
May 29, 2024
|
Re-running CI as the DAO app was skipped, otherwise lgtm |
K1-R1
approved these changes
May 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Changes
The following apps have been updated to forc 0.60.0, fuel core 0.26.0, fuels 0.62.0