Add SRC-7 helper functions #194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bitzoic
added
New Feature
Braqzen
reviewed
Sep 13, 2023
Braqzen
reviewed
Oct 2, 2023
| match metadata { | ||
| Metadata::Int(data) => { | ||
| write(hashed_key, 0, data); | ||
| write(sha256((hashed_key, self.slot)), 0, 0); |
There was a problem hiding this comment.
Why does the last number in the second write increment for each metadata type while the first write seems to remain the same?
Doesn't the hashed key keep the collisions down to 0?
There was a problem hiding this comment.
The first write stores the data itself while the second write describes the type. This is needed as String and Bytes are pointer types and therefore cannot be stored, hence the use of the StorageMetadata type in the first place
There was a problem hiding this comment.
If you have a better suggestion as to how to handle this case I'm all ears
K1-R1
approved these changes
Oct 3, 2023
Braqzen
approved these changes
Oct 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Changes
The following changes have been made:
Metadatatype of the SRC-7 standardNotes