Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: updates for docs-hub #103

Merged
merged 15 commits into from
Jun 5, 2024
Merged

docs: updates for docs-hub #103

merged 15 commits into from
Jun 5, 2024

Conversation

sarahschwartz
Copy link
Contributor

@sarahschwartz sarahschwartz commented May 30, 2024

Type of change

  • Documentation

Changes

The following changes have been made:

  • changes to prepare docs for the docs-hub, including renaming them, adding code examples, updating headers to follow accessibility guidelines
  • added CI tests for docs-hub compatibility

You can preview the changes on the docs-hub here: https://docs-hub-git-sarah-sway-standards-fuel-labs.vercel.app/docs/sway-standards/

@sarahschwartz sarahschwartz self-assigned this May 30, 2024
@sarahschwartz sarahschwartz added the Documentation Improvements or additions to documentation label May 30, 2024
@sarahschwartz sarahschwartz marked this pull request as ready for review May 31, 2024 20:51
@sarahschwartz sarahschwartz requested a review from a team as a code owner May 31, 2024 20:51
luizstacio
luizstacio previously approved these changes Jun 3, 2024
bitzoic
bitzoic previously approved these changes Jun 3, 2024
Copy link
Member

@bitzoic bitzoic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason the Abstract section header was removed for all the standards?

@bitzoic bitzoic requested a review from a team June 3, 2024 03:09
@sarahschwartz
Copy link
Contributor Author

sarahschwartz commented Jun 3, 2024

Is there a reason the Abstract section header was removed for all the standards?

it just seemed redundant/implied, but I can add it back if you want.

K1-R1
K1-R1 previously approved these changes Jun 3, 2024
@sarahschwartz sarahschwartz dismissed stale reviews from K1-R1, bitzoic, and luizstacio via 3f6f73c June 4, 2024 13:51
@sarahschwartz sarahschwartz requested a review from bitzoic June 4, 2024 13:52
@bitzoic bitzoic requested a review from K1-R1 June 5, 2024 02:34
@bitzoic bitzoic requested a review from a team June 5, 2024 02:34
@sarahschwartz sarahschwartz requested a review from luizstacio June 5, 2024 14:33
@sarahschwartz sarahschwartz merged commit 1e567c6 into master Jun 5, 2024
6 checks passed
@sarahschwartz sarahschwartz deleted the sarah/docs branch June 5, 2024 15:32
This was referenced Jun 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants