Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add proxy_owner() function to the SRC-14 standard #107

Merged
merged 4 commits into from
Jun 11, 2024

Conversation

bitzoic
Copy link
Member

@bitzoic bitzoic commented Jun 11, 2024

Type of change

  • Bug fix
  • New feature

Changes

The following changes have been made:

  • Adds proxy_owner() function
  • Discourages the use of the SRC-5 ownership standard when implementing the SRC-14 standard
  • Updates examples with proxy_owner()

Checklist

  • I have linked to any relevant issues.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have updated the documentation where relevant (API docs, the reference, and the Sway book).
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added (or requested a maintainer to add) the necessary Breaking* or New Feature labels where relevant.
  • I have done my best to ensure that my PR adheres to the Fuel Labs Code Review Standards.
  • I have requested a review from the relevant team or maintainers.
  • I have updated the changelog to reflect the changes on this PR.

@bitzoic bitzoic added Bug Something isn't working SRC 14 Label used to filter for the standard issue labels Jun 11, 2024
@bitzoic bitzoic requested review from IGI-111, DefiCake and a team June 11, 2024 06:04
@bitzoic bitzoic self-assigned this Jun 11, 2024
@IGI-111
Copy link
Contributor

IGI-111 commented Jun 11, 2024

What's the reasoning behind having a specific function instead of implementing SRC5?

Edit: never mind I read the rest of the change

@IGI-111 IGI-111 merged commit 87b39df into master Jun 11, 2024
6 checks passed
@IGI-111 IGI-111 deleted the bitzoic-update-src-14 branch June 11, 2024 16:12
@bitzoic bitzoic mentioned this pull request Jun 12, 2024
9 tasks
This was referenced Jun 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working SRC 14 Label used to filter for the standard issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants