Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SRC-2 Inline Documentation #11

Merged
merged 9 commits into from
Jul 14, 2023
Merged

SRC-2 Inline Documentation #11

merged 9 commits into from
Jul 14, 2023

Conversation

bitzoic
Copy link
Member

@bitzoic bitzoic commented Jun 13, 2023 •
edited
Loading

Type of change

  • New standard

Changes

The following changes have been made:

  • Added Specification

Notes

  • There have been recent changes to the LSP to support this standard.
  • This PR will fail CI until SRC-5 Ownership #10 is merged

Related Issues

Closes #5

@bitzoic bitzoic added the SRC 2 Label used to filter for the standard issue label Jun 13, 2023
@bitzoic bitzoic self-assigned this Jun 13, 2023
@bitzoic bitzoic requested a review from a team as a code owner June 13, 2023 14:17
@bitzoic bitzoic linked an issue Jun 13, 2023 that may be closed by this pull request
SRC-2; Inline Documentation Standard #5
Closed
dmihal
dmihal previously approved these changes Jun 13, 2023
View reviewed changes
Braqzen
Braqzen reviewed Jun 15, 2023
View reviewed changes
standards/src_2/README.md Show resolved Hide resolved
standards/src_2/README.md Outdated Show resolved Hide resolved
standards/src_2/README.md Outdated Show resolved Hide resolved
standards/src_2/README.md Show resolved Hide resolved
standards/src_2/README.md Outdated Show resolved Hide resolved
standards/src_2/README.md Show resolved Hide resolved
standards/src_2/README.md Show resolved Hide resolved
dmihal
dmihal previously approved these changes Jun 15, 2023
View reviewed changes
@bitzoic bitzoic requested review from Voxelot, SilentCicero, a team, dmihal and Braqzen June 16, 2023 16:08
IGI-111
IGI-111 reviewed Jul 11, 2023
View reviewed changes
standards/src_2/README.md Outdated Show resolved Hide resolved
JoshuaBatty
JoshuaBatty previously approved these changes Jul 13, 2023
View reviewed changes
@JoshuaBatty JoshuaBatty requested a review from a team July 13, 2023 23:29
@bitzoic bitzoic merged commit 47c2885 into master Jul 14, 2023
@bitzoic bitzoic deleted the bitzoic-5 branch November 6, 2023 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IGI-111 IGI-111 IGI-111 left review comments

@JoshuaBatty JoshuaBatty JoshuaBatty left review comments

@Voxelot Voxelot Awaiting requested review from Voxelot

@SilentCicero SilentCicero Awaiting requested review from SilentCicero

@dmihal dmihal Awaiting requested review from dmihal

@Braqzen Braqzen Awaiting requested review from Braqzen

Assignees

@bitzoic bitzoic

Labels
SRC 2 Label used to filter for the standard issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

SRC-2; Inline Documentation Standard
5 participants
@bitzoic @JoshuaBatty @dmihal @IGI-111 @Braqzen