Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SRC-2 Change "Panic" to "Revert" terminology #12

Merged
merged 1 commit into from
Aug 8, 2023
Merged

SRC-2 Change "Panic" to "Revert" terminology #12

merged 1 commit into from
Aug 8, 2023

Conversation

bitzoic
Copy link
Member

@bitzoic bitzoic commented Aug 8, 2023

Type of change

  • Other (describe below)

Changes

The following changes have been made:

  • Changing the inline documentation title from "Panic" to "Revert" to move away from Rust conventions.

@bitzoic bitzoic added the SRC 2 Label used to filter for the standard issue label Aug 8, 2023
@bitzoic bitzoic self-assigned this Aug 8, 2023
@bitzoic bitzoic requested a review from a team as a code owner August 8, 2023 15:11
@bitzoic bitzoic mentioned this pull request Aug 8, 2023
Merged
7 tasks
@bitzoic bitzoic merged commit 06e24db into master Aug 8, 2023
@SwayStar123
Copy link
Member

Um, shouldnt we have both since predicates can panic? (Contracts revert, predicates panic) @Braqzen @bitzoic

@Braqzen
Copy link
Contributor

Braqzen commented Aug 10, 2023

Um, shouldnt we have both since predicates can panic? (Contracts revert, predicates panic) @Braqzen @bitzoic

Predicates crash and do not revert and return gas?
Even if that is the case then reverts are canonical and take priority.

@bitzoic bitzoic deleted the bitzoic-src-2-revert branch November 6, 2023 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Braqzen Braqzen Braqzen approved these changes

@K1-R1 K1-R1 K1-R1 approved these changes

Assignees

@bitzoic bitzoic

Labels
SRC 2 Label used to filter for the standard issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bitzoic @SwayStar123 @Braqzen @K1-R1