Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add required logging of SRC-20 to SRC-6 examples #151

Merged
merged 12 commits into from
Sep 17, 2024
Merged

Add required logging of SRC-20 to SRC-6 examples #151

merged 12 commits into from
Sep 17, 2024

Conversation

SwayStar123
Copy link
Member

@SwayStar123 SwayStar123 commented Sep 10, 2024 •
edited
Loading

Type of change

  • Bug fix

Changes

The following changes have been made:

  • Adds logging of values of SRC-20 whenever they are updated in SRC-6 examples
  • Formats the examples of src6
  • Fixes some inline comments

Checklist

  • I have linked to any relevant issues.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have updated the documentation where relevant (API docs, the reference, and the Sway book).
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added (or requested a maintainer to add) the necessary Breaking* or New Feature labels where relevant.
  • I have done my best to ensure that my PR adheres to the Fuel Labs Code Review Standards.
  • I have requested a review from the relevant team or maintainers.
  • I have updated the changelog to reflect the changes on this PR.

@SwayStar123 SwayStar123 self-assigned this Sep 10, 2024
@SwayStar123 SwayStar123 added Bug Something isn't working Enhancement New feature or request labels Sep 10, 2024
@SwayStar123 SwayStar123 marked this pull request as ready for review September 10, 2024 06:00
@SwayStar123 SwayStar123 requested a review from a team as a code owner September 10, 2024 06:00
bitzoic
bitzoic requested changes Sep 11, 2024
View reviewed changes
examples/src6-vault/single_asset_single_sub_vault/src/main.sw Outdated Show resolved Hide resolved
examples/src6-vault/single_asset_single_sub_vault/src/main.sw Outdated Show resolved Hide resolved
examples/src6-vault/multi_asset_vault/src/main.sw Outdated Show resolved Hide resolved
examples/src6-vault/multi_asset_vault/src/main.sw Outdated Show resolved Hide resolved
examples/src6-vault/single_asset_single_sub_vault/src/main.sw Outdated Show resolved Hide resolved
examples/src6-vault/multi_asset_vault/src/main.sw Show resolved Hide resolved
examples/src6-vault/single_asset_vault/src/main.sw Show resolved Hide resolved
examples/src6-vault/single_asset_vault/src/main.sw Outdated Show resolved Hide resolved
examples/src6-vault/single_asset_vault/src/main.sw Outdated Show resolved Hide resolved
@SwayStar123 SwayStar123 requested a review from bitzoic September 11, 2024 12:31
@K1-R1 K1-R1 requested a review from a team September 16, 2024 16:03
@SwayStar123 SwayStar123 merged commit ee95fad into master Sep 17, 2024
14 checks passed
@bitzoic bitzoic mentioned this pull request Nov 11, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@K1-R1 K1-R1 K1-R1 approved these changes

@bitzoic bitzoic bitzoic approved these changes

Assignees

@SwayStar123 SwayStar123

Labels
Bug Something isn't working Enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SwayStar123 @bitzoic @K1-R1