Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Vault standard; SRC-6 #24
Vault standard; SRC-6 #24
Changes from 3 commits
fb9e76f
bdbc811
d99d57b
90fef86
eaae21d
614a197
2967abc
0a25bf9
ac2f913
8d9f65e
ad9d835
f7a804c
5b07a7c
2b7ebf3
610bfca
0573079
56f2a44
5458c9b
e3ae07e
9fb0e64
a49f725
e82ed1a
c2821d6
9a248c8
7d202c7
789b449
c015568
505f119
0aa72b7
80a651d
b9733f1
c3bcd22
e069a72
96780da
e071263
4d4e87b
2ab2c86
4efbc42
f84708b
8a92553
6fc1d91
c03c459
c49c545
cbb1ad4
ab37a33
35310ca
8289539
6cb7bd0
18361e5
00062e2
a012f66
1602385
c71f8ba
3c02c47
88c4a78
3f85686
60d7860
f7ee8ba
e09d6ce
3256873
b1af20e
3e7535f
9d87ba9
82c4e13
8b5d969
c16209f
db03515
ecb4ec3
9e447b6
2713412
e34bf56
3242e5d
1b8d424
8c019fb
fa3b660
b0a5928
d498552
0f321c5
e4f843a
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe mention how a standardized vault increases composability, such as an AMM that allows trading assets based on the underlying assets... wallets that are aware of assets held in a vault, etc.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be an example, not the specification. Should be listed out such as here: https://github.com/FuelLabs/sway-standards/tree/master/standards/src_5#state
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Im confused, thats also just the specification enum, just without comments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if we should include something about how a vault can "lie" about the underlying?
Ex, if a vault says some asset represents USDC, there's no guarantee that the vault actually represents USDC (may be a consideration for wallets)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a poor comment. It does not inform the user in any way. It's too broad. Also, isn't this supposed to return 0 if it would not return a value i.e. revert? Similar to withdrawal below
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What makes you think its supposed to return 0? I dont think i mentioned that anywhere
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thinking about usage.
If you attempt to view what value it would return it shouldn't crash. It should return some value such as an error or 0 if that 0 makes sense as a default.