Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix inline docs for SRC-20 standard #41

Merged
merged 1 commit into from
Nov 22, 2023
Merged

Fix inline docs for SRC-20 standard #41

merged 1 commit into from
Nov 22, 2023

Conversation

bitzoic
Copy link
Member

@bitzoic bitzoic commented Nov 20, 2023

Type of change

  • Documentation

Changes

The following changes have been made:

  • Inline documentation for the SRC-20 standard did not unwrap any Options and thus would fail. This has been fixed.

@bitzoic bitzoic added Bug Something isn't working Documentation Improvements or additions to documentation SRC 20 Label used to filter for the standard issue labels Nov 20, 2023
@bitzoic bitzoic self-assigned this Nov 20, 2023
@bitzoic bitzoic requested a review from a team as a code owner November 20, 2023 09:06
Braqzen
Braqzen approved these changes Nov 20, 2023
View reviewed changes
Copy link
Contributor

@Braqzen Braqzen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd consider unwrap_or(0) over unwrap().

@bitzoic bitzoic requested a review from a team November 21, 2023 08:43
@bitzoic bitzoic merged commit c8cc6fc into master Nov 22, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Braqzen Braqzen Braqzen approved these changes

@dmihal dmihal dmihal approved these changes

Assignees

@bitzoic bitzoic

Labels
Bug Something isn't working Documentation Improvements or additions to documentation SRC 20 Label used to filter for the standard issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bitzoic @dmihal @Braqzen