Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove duplicate adjustment of total_supply in SRC6 examples #61

Merged
merged 2 commits into from
Feb 20, 2024
Merged

Remove duplicate adjustment of total_supply in SRC6 examples #61

merged 2 commits into from
Feb 20, 2024

Conversation

SwayStar123
Copy link
Member

Type of change

  • Bug fix

Changes

The following changes have been made:

  • Duplicate total supply adjustments have been removed from the src6 examples
  • The return for the total supply in single token single subvault has been fixed to return None if the wrong assetid is passed in as the parameter.

Notes

  • Note 1

Related Issues

Closes #60

@SwayStar123 SwayStar123 marked this pull request as ready for review February 19, 2024 06:54
@SwayStar123 SwayStar123 requested a review from a team as a code owner February 19, 2024 06:54
bitzoic
bitzoic approved these changes Feb 20, 2024
View reviewed changes
Copy link
Member

@bitzoic bitzoic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps we should begin adding tests to the examples so this doesn't happen again

@SwayStar123 SwayStar123 merged commit ce382b6 into master Feb 20, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bitzoic bitzoic bitzoic approved these changes

@dmihal dmihal dmihal approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: SRC6 examples double count total supply changes
3 participants
@SwayStar123 @dmihal @bitzoic