Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SRC-14 Simple Proxy Standard #94

Merged
merged 8 commits into from
May 28, 2024
Merged

SRC-14 Simple Proxy Standard #94

merged 8 commits into from
May 28, 2024

Conversation

IGI-111
Copy link
Contributor

@IGI-111 IGI-111 commented May 21, 2024

Type of change

New Standard

Changes

The following changes have been made:

  • Add the SRC-14 standard specification, abi and examples

Related Issues

FuelLabs/sway-rfcs#39

@IGI-111 IGI-111 requested a review from a team as a code owner May 21, 2024 10:52
@IGI-111 IGI-111 self-assigned this May 21, 2024
@IGI-111 IGI-111 requested review from JoshuaBatty and a team May 21, 2024 10:53
@IGI-111 IGI-111 force-pushed the IGI-111/SRC-14 branch 2 times, most recently from 3a9f4ed to bf9b39c Compare May 21, 2024 10:58
@JoshuaBatty JoshuaBatty requested a review from a team May 21, 2024 23:30
@JoshuaBatty
Copy link
Member

Nice work, want a little bit more time to mull on the proposal but from my initial passes the syntax looks well thought out.

Copy link
Member

@bitzoic bitzoic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very cool!!

@SwayStar123 Could you please use this standard for the proxy work you are doing?

standards/src/src14.sw Show resolved Hide resolved
standards/src/src14.sw Outdated Show resolved Hide resolved
standards/src/src14.sw Outdated Show resolved Hide resolved
SRCs/src-14.md Outdated Show resolved Hide resolved
SRCs/src-14.md Show resolved Hide resolved
@bitzoic
Copy link
Member

bitzoic commented May 22, 2024

Dependent on #95

@IGI-111 IGI-111 requested a review from bitzoic May 22, 2024 10:00
IGI-111 and others added 2 commits May 22, 2024 18:36
Co-authored-by: Cameron Carstens <bitzoic.eth@gmail.com>
SRCs/src-14.md Outdated Show resolved Hide resolved
@bitzoic bitzoic requested a review from a team May 23, 2024 07:36
@JoshuaBatty
Copy link
Member

Are we missing a section about auto generating the proxy contract byte code? I'm not 100% clear how that part is going to be implemented.

SwayStar123
SwayStar123 previously approved these changes May 24, 2024
SRCs/src-14.md Outdated Show resolved Hide resolved
SRCs/src-14.md Outdated Show resolved Hide resolved
SRCs/src-14.md Outdated Show resolved Hide resolved
IGI-111 and others added 2 commits May 25, 2024 05:48
Co-authored-by: SwayStar123 <46050679+SwayStar123@users.noreply.github.com>
Co-authored-by: Cameron Carstens <bitzoic.eth@gmail.com>
@IGI-111 IGI-111 requested a review from SwayStar123 May 25, 2024 14:45
SwayStar123
SwayStar123 previously approved these changes May 26, 2024
tritao
tritao previously approved these changes May 27, 2024
Copy link
Contributor

@tritao tritao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some minor suggestions, looks good otherwise.

SRCs/src-14.md Show resolved Hide resolved
SRCs/src-14.md Outdated Show resolved Hide resolved
SRCs/src-14.md Outdated Show resolved Hide resolved
SRCs/src-14.md Outdated Show resolved Hide resolved
@IGI-111 IGI-111 dismissed stale reviews from tritao and SwayStar123 via 81b3afe May 27, 2024 18:00
IGI-111 and others added 2 commits May 27, 2024 22:00
Co-authored-by: João Matos <joao@tritao.eu>
@IGI-111 IGI-111 requested review from tritao and SwayStar123 May 27, 2024 18:02
Copy link
Member

@kayagokalp kayagokalp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

SRCs/src-14.md Show resolved Hide resolved
@IGI-111 IGI-111 merged commit cb44ed9 into master May 28, 2024
2 checks passed
@IGI-111 IGI-111 deleted the IGI-111/SRC-14 branch May 28, 2024 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants