Support hover links #152
Merged
Support hover links #152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
IGI-111
added a commit
to FuelLabs/sway
that referenced
this pull request
May 10, 2023
## Description Closes #2851 #2852 Related, this code is needed for the links to work: FuelLabs/sway-vscode-plugin#152 There are two types of links: go to definition and go to implementations. It should be working for: - structs - enums - traits - variables - functions - function parameters - struct fields Note: it isn't working for ABI at the moment. <img width="500" alt="image" src="https://user-images.githubusercontent.com/47993817/236133554-aa79b4ed-f2db-4de4-baf9-edae42b6d44a.png"> <img width="617" alt="image" src="https://user-images.githubusercontent.com/47993817/236133705-d9990ea1-61d6-4abc-a8f8-ee41d8a5658a.png"> <img width="1138" alt="image" src="https://user-images.githubusercontent.com/47993817/236133746-0fdf1ede-ff49-46ce-bb2a-41ce18503c6e.png"> ## Checklist - [x] I have linked to any relevant issues. - [x] I have commented my code, particularly in hard-to-understand areas. - [ ] I have updated the documentation where relevant (API docs, the reference, and the Sway book). - [ ] I have added tests that prove my fix is effective or that my feature works. - [ ] I have added (or requested a maintainer to add) the necessary `Breaking*` or `New Feature` labels where relevant. - [x] I have done my best to ensure that my PR adheres to [the Fuel Labs Code Review Standards](https://github.com/FuelLabs/rfcs/blob/master/text/code-standards/external-contributors.md). - [ ] I have requested a review from the relevant team or maintainers. --------- Co-authored-by: IGI-111 <igi-111@protonmail.com> Co-authored-by: Kaya Gökalp <kaya.gokalp@fuel.sh> Co-authored-by: Joshua Batty <joshpbatty@gmail.com>
sdankel
added a commit
that referenced
this pull request
Apr 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds commands that are linked to from the hover docs in markdown.
Related FuelLabs/sway#4532